Skip to content

Simplify props.py - #1511

Open
RJPercival wants to merge 1 commit into
graphql-python:masterfrom
RJPercival:patch-1
Open

Simplify props.py#1511
RJPercival wants to merge 1 commit into
graphql-python:masterfrom
RJPercival:patch-1

Conversation

@RJPercival

@RJPercival RJPercival commented Jul 4, 2023

Copy link
Copy Markdown

It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.

This could be simplified further, e.g. by skipping any attributes that start with an underscore, but that would be a behavioural change, whereas this PR is a pure refactoring.

It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.
@erikwrede

Copy link
Copy Markdown
Member

Thanks for the PR @RJPercival 🙂
Could you please run the pre-commit hooks before commiting, so that the linter runs? Feel free to tag me after the PR is updated, will merge then. 😊

@codecov

codecov Bot commented Jul 19, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.00%. Comparing base (d77d0b0) to head (6d609db).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   96.01%   96.00%   -0.01%     
==========================================
  Files          51       51              
  Lines        1755     1753       -2     
==========================================
- Hits         1685     1683       -2     
  Misses         70       70              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants