Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,8 @@ Theme fixes:
integer-valued (e.g. `"$1,000"`), and place the negative sign in front of the
currency symbol (e.g. `"-$1.50"` rather than `"$-1.50"`).
(#618, #623 @grantmcdermott)
- Fixed `xlab = NA` / `ylab = NA` gotchas: a barplot with `xlab = NA` no longer
errors, and spineplots no longer clip their category and tick labels when
`xlab`/`ylab` are set to `NA` under a dynamic theme. (#635 @grantmcdermott)
- Fixed `xlab = NA` / `ylab = NA` gotchas for `"barplot"`, `"spineplot"`, and
`"ridge"` types. (#635, #650 @grantmcdermott)
- `tinyplot_add()` (`plt_add()`) now captures its arguments unevaluated, so
arguments that rely on non-standard evaluation against `data` (e.g.,
`plt_add(..., subset = <>)`) resolve correctly instead of erroring with
Expand Down
8 changes: 5 additions & 3 deletions R/tinyplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -1095,9 +1095,11 @@ tinyplot.default = function(

# Types that suppress the standard axes (xaxt/yaxt = "n") only because they
# draw their own in the same place (e.g. spineplot category + numeric labels
# via spine_axis()). Their tick-row margin must still be reserved, else the
# self-drawn labels clip when xlab/ylab = NA makes label_extent = 0 (#635).
.self_axis = identical(type, "spineplot")
# via spine_axis(); ridge y-axis category labels via tinyAxis()). Their
# tick-row margin must still be reserved, else the self-drawn labels clip --
# or, under las 0/1 where mar is further shifted, error -- when xlab/ylab = NA
# makes label_extent = 0 (#635, #650).
.self_axis = type %in% c("spineplot", "ridge")

.dyn = c(
dynmar_side(1, xlab, main = main, sub = sub,
Expand Down
Loading