Allow non-trailing slash in escrow URL#124
Allow non-trailing slash in escrow URL#124arubdesu wants to merge 1 commit intograhamgilbert:masterfrom
Conversation
Add if with return for case, tests that cover new behavior, assurance in test that only this path will lead to this behavior
|
Oh, and as a reminder this is because I used an HTTP api gateway to 'forward' escrow's into the network our CryptServer is on, which doesn't allow the trailing slash and 'default' is the AWS... default naming of the stage we deployed. |
|
I would prefer to not hard code specific implementation details for your environment. Is there any reason you cannot set your server url to what you need? |
|
It's certainly not the communities problem that our infrastructure implementation is weird, but linux and windows 'agent' interfaces are using this same URL so migrating has more friction/requires more coordination for something as vital as FDE escrow. I'm honestly not sure if the other API gateway options (lambda-less and REST-ful) would even fix the incompatibility with trailing slash. A flag to not validate/enforce trailing slash would work for me just the same, should I add a pref or something instead? |
|
I think the pref to not enforce the trailing slash makes sense |
Add if with return for case, tests that cover new behavior, assurance in test that only this path will lead to this behavior
We can definitely discuss how I separated out a new MockPref (I was following a colleagues guidance), it would make sense for the whole test struct to ride alongside the implementation in the other... package? Maybe? Anyway pardon I hacked it in, I can't even get a test build spit out at the moment because no homebrew/I've forgotten how to luggage 😅