chore: import eslint config#2723
Open
jackw wants to merge 64 commits into
Open
Conversation
|
|
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
Zoltan/refactor and version bump
* Minor changes * Match dependency versions with other @grafana packages * Version bump
* Use dependencies for now ... so that it's not installed to a plugin's node_modules/@grafana/toolkit/node_modules dir but to the parent one where eslint can find it. We can reverse this when we migrate from yarn back to npm (v7+) which installs peerDependencies. * Version bump
* Use hard dependency versions ... to match toolkit and core because building plugins with toolkit cannot find eslint plugins; perhaps due to version collisions * Version bump
Adds eslint-plugin-react with recommended setings enabled
chore: update repository for github packages
fix composable flat configs
Chore: Use get-vault-secrets without exporting env variables
Chore: Add CODEOWNERS file
| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | eslint | 9.12.0 | 9.38.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com> Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
Mitigates supply-chain risk from malicious post-install hooks.
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
) * chore: make the package esm only and update some deps * chore(yarn): update lock file * feat: remove legacy config * feat: add linter.config for typings * Wip * Wip * feat: tidy up changelog and deps * chore: delete package-lock.json file * Update index.js Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> * revert: remove disabled react-hooks rules for grafana/grafana * chore(deps): bump react-hooks plugin to 7.1.x to support eslint 10 * docs(changelog): add eslint 10 support note --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>
jackw
force-pushed
the
jackw/import-eslint-config-grafana
branch
from
0dcdf21 to
44c2fd7
Compare
jackw
force-pushed
the
jackw/import-eslint-config-grafana
branch
from
44c2fd7 to
dcd1900
Compare
jackw
force-pushed
the
jackw/import-eslint-config-grafana
branch
from
dcd1900 to
3213848
Compare
joshhunt
approved these changes
Jun 11, 2026
sunker
reviewed
Jun 12, 2026
sunker
left a comment
sunker
left a comment
Contributor
There was a problem hiding this comment.
Not sure if it would make sense to dogfood this by letting the other packages in this monorepo use local package rather than published version?
| This package contains a single flat config object which can be imported like so: | ||
|
|
||
| ```js | ||
| const grafanaConfig = require("@grafana/eslint-config/flat"); |
Collaborator
Author
There was a problem hiding this comment.
No it's not. I'll do it in a separate PR to validate releases are working. Thanks @sunker !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The eslint config package that lives in https://github.com/grafana/eslint-config-grafana goes somewhat unnoticed and requires work to bring it up to speed with our security best practices. Rather than duplicate a load of CI / config I think it makes more sense to bring it over here where we'll keep a closer eye on it and get all the security hardening efforts made in this repo for free.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Important
We must do the following once merged and before doing any releases: