Conversation
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Pull request overview
Updates a few dependencies and related references across the repo.
Changes:
- Bump
expressinplugin-docs-cli - Remove the root
webpack-dev-serveroverride - Update plugin metadata docs and pin a newer
tj-actions/changed-filescommit
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/plugin-docs-cli/package.json | Bumps express dependency version. |
| package.json | Removes the overrides entry for webpack-dev-server. |
| docusaurus/docs/reference/metadata.md | Updates wording/allowed values description for category. |
| .github/actions/change-detection/action.yml | Pins tj-actions/changed-files to a newer commit (v47.0.4). |
f3bc39b to
02b1ce5
Compare
mckn
left a comment
There was a problem hiding this comment.
Looks good but I have not tested it locally. Any more details on why we don't need the webpack-dev-server override anymore?
| | **buildMode** | `string` | The build mode of the plugin. This field is set automatically at build time, so it should not be provided manually.<br/> | | | ||
| | **builtIn** | `boolean` | [internal only] Indicates whether the plugin is developed and shipped as part of Grafana. Also known as a 'core plugin'.<br/> | | | ||
| | **category** | `string` | Plugin category used on the Add data source page.<br/>Possible values are: `"tsdb"`, `"logging"`, `"cloud"`, `"tracing"`, `"profiling"`, `"sql"`, `"enterprise"`, `"iot"`, `"other"`<br/> | | | ||
| | **category** | `string` | Plugin category used on the Add new connection page. Can be one from the list: "tsdb", "logging", "cloud", "tracing", "profiling", "sql", "enterprise", "iot", "other", empty string or custom string<br/> | | |
There was a problem hiding this comment.
Should this change be part of this PR? I'm happy to keep it just a bit confusing that it lives in a bump deps PR.
There was a problem hiding this comment.
not necessarily - it was just blocking the ci pipeline. Let me rebase it - it was probably already resolved
- @grafana/plugin-docs-cli@0.0.3 - @grafana/plugin-docs-parser@0.0.2 - @grafana/plugin-e2e@3.3.3
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
- @grafana/create-plugin@6.10.2
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- @grafana/plugin-e2e@3.4.0
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
- @grafana/create-plugin@6.10.3
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
- @grafana/create-plugin@6.11.0
- @grafana/create-plugin@7.0.0
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
|
opening smaller PRs |
Updating some dependencies:
I cant really bump tar as lerna gets weird and nx command gets lost (nx: command not found). Also it seems like its peer dependencies are not yet fully up to date so maybe it makes to sense to bump lerna yet anyway.