Skip to content

Conversation

@sudonatalie
Copy link
Contributor

Add a test for compound assignment to a vector with a swizzle on the right hand side. This case covers the bug reported in https://crbug.com/480933709 and will be fixed in WebGPU with https://dawn-review.googlesource.com/c/dawn/+/288435.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@sudonatalie sudonatalie requested a review from dj2 February 2, 2026 16:42
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Results for build job (at 2da1af1):

+webgpu:shader,validation,decl,assignment_statement:compound_assignment_with_swizzle:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 285934 cases, 2344827 subcases
+TOTAL: 285935 cases, 2344828 subcases

@sudonatalie sudonatalie enabled auto-merge (squash) February 2, 2026 18:17
@sudonatalie sudonatalie merged commit b07fa2f into gpuweb:main Feb 2, 2026
1 check passed
@sudonatalie sudonatalie deleted the swizzle-compound-bug branch February 2, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants