Skip to content

Conversation

@haoxli
Copy link
Contributor

@haoxli haoxli commented Jan 14, 2026

Added a per-test endTestScope timeout function so heavy cases can extend the time without slowing down the rest of the suite, and used it to give the 64K timestamp-query stress test run extra headroom, avoiding flakes while leaving the default 5000ms limit untouched elsewhere.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

Added a per-test endTestScope timeout function so heavy cases can extend
the time without slowing down the rest of the suite, and used it to give
the 64K timestamp-query stress test run extra headroom, avoiding flakes
while leaving the default 5000ms limit untouched elsewhere.
@haoxli haoxli requested a review from kainino0x January 14, 2026 07:39
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Results for build job (at 41ddee9):

 Test case/subcase counts did not change.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some nits, LGTM

  • try should be around the whole test just in case anything throws an exception (even though it shouldn't, and IIRC the device will get discarded afterward anyway if that happens)
  • comments to explain what's going on

@kainino0x kainino0x enabled auto-merge (squash) January 26, 2026 21:06
@kainino0x kainino0x merged commit f9e7872 into gpuweb:main Jan 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants