Run batchFinishedCallback on processBatch to catch unhandled rejections by test functions#3844
Merged
kainino0x merged 4 commits intogpuweb:mainfrom Jul 15, 2024
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
Care to review @kainino0x? |
Collaborator
|
Sorry, had this in my review inbox but been swamped this week! |
kainino0x
reviewed
Jul 13, 2024
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
kainino0x
reviewed
Jul 15, 2024
kainino0x
approved these changes
Jul 15, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3809 (I verified that it fixes the timeout issue in servo)
Related #3158, but I think this fix is more appropriate (and less invasive).
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.