Cache load_inline Torch headers in a Modal Volume - #527
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
msaroufim
marked this pull request as ready for review
September 7, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse Torch C++ precompiled headers across Modal submissions. A CPU warmup writes a Volume; GPU runners mount it read-only and disable Modal API writes. The deployment workflow warms the cache before replacing runners.
Submissions are expected to use
load_inline(), which uses the cache automatically; leaveuse_pch=False. Keys include installed headers, compiler, host flags, and include environment. Misses compile normally. CUDA templates and submission objects are not cached.Measured on T4, CUDA 13.3, PyTorch 2.12, with fresh containers and normal Ninja parallelism:
no_implicit_headers=TrueThe GEMM instantiates two SM75 tile configurations with FP16 inputs and FP32 accumulation/output. PCH saved 37% of build time with minimal CUDA headers, but only 5% with default headers (overlapping timing ranges). NVCC remains the bottleneck. All 160 GEMM checks passed; maximum absolute error was 8.53e-6.
Unwarmed host flags miss the cache: a
load_inline()case measured 18.08s → 20.30s. Separate-container variability means this difference does not isolate wrapper overhead.CXX=/usr/bin/g++bypasses the wrapper.Validation: the implementation passed all four GitHub checks, 41 local tests, 76 additional correctness checks (including supplemental compiler diagnostics), and all eight warmup profiles. The latest change only updates documentation; Ruff and diff checks pass. Separate untimed GCC traces confirm PCH consumption.
Usage and reproduction · Per-container results and Modal runs