Clarify MathDx usage with load_inline#517
Draft
msaroufim wants to merge 1 commit into
Draft
Conversation
msaroufim
force-pushed
the
agent/enable-mathdx-headers
branch
from
July 20, 2026 18:35
9f57e4f to
176b12c
Compare
msaroufim
changed the title
[skip ci]
msaroufim
force-pushed
the
agent/enable-mathdx-headers
branch
from
July 20, 2026 18:37
176b12c to
8744ef1
Compare
msaroufim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the existing Modal runner guidance: MathDx headers are already installed and exported through
CPLUS_INCLUDE_PATH, soload_inlineusers only need to put#include <cublasdx.hpp>incuda_sourcesrather thancpp_sources.Why
load_inlinecompilescpp_sourceswith the host C++ compiler andcuda_sourceswith NVCC. cuBLASDx belongs in the CUDA compilation unit; no additional Kernelbot image setting or submission compile flag is required.Impact
Comment-only change in
modal_runner.py. No dependency, image, example, or test changes, and no Modal image was deployed.Validation
uv run --extra dev ruff check src/runners/modal_runner.pygit diff --check