Repository navigation
feat: limit request body size - #1073
Merged
Merged
Conversation
Wrap every request body in http.MaxBytesReader so oversized bodies are cut off before they are read completely. The limit defaults to 10 MiB and can be changed with GOTIFY_SERVER_MAX_BODY_BYTES (0 disables it).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 76.54% 76.58% +0.03%
==========================================
Files 68 68
Lines 3714 3720 +6
==========================================
+ Hits 2843 2849 +6
Misses 658 658
Partials 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #950
Adds a middleware in
router.Createthat wraps every request body inhttp.MaxBytesReader. The limit is set withGOTIFY_SERVER_MAX_BODY_BYTES(default 10 MiB,0disables it).Oversized requests get a 413 from endpoints that bind JSON or form data.
/plugin/{id}/configand the application image upload still return 500, since those handlers treat any read error as a server error. I left them unchanged as planned, but can switch them to 413 if you'd like.go test -race ./...passes.