Skip to content

fix(windows): force UTF-8 console codepage to prevent non-ASCII mojibake#825

Open
nuthalapativarun wants to merge 1 commit into
googleworkspace:mainfrom
nuthalapativarun:fix/742-windows-utf8-console
Open

fix(windows): force UTF-8 console codepage to prevent non-ASCII mojibake#825
nuthalapativarun wants to merge 1 commit into
googleworkspace:mainfrom
nuthalapativarun:fix/742-windows-utf8-console

Conversation

@nuthalapativarun
Copy link
Copy Markdown

Summary

On Windows, the default console codepage is CP-1252 (or the system OEM codepage), which mangles non-ASCII characters (e.g. accented names, CJK characters) in API responses.

This change calls SetConsoleOutputCP(65001) at startup when running on Windows, forcing the console to interpret output as UTF-8.

Fixes #742

Checklist

  • cargo fmt --all passed
  • cargo clippy -- -D warnings passed
  • cargo test passed
  • Changeset file added (patch bump)
  • No new dependencies — uses extern "system" FFI

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 1, 2026

🦋 Changeset detected

Latest commit: 8978279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label Jun 1, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where non-ASCII characters are incorrectly displayed in the console on Windows systems. By explicitly setting the console output code page to UTF-8 during initialization, the application ensures consistent character rendering across different environments.

Highlights

  • Windows Console Encoding: Implemented a fix to force UTF-8 encoding on Windows consoles by calling SetConsoleOutputCP(65001) at application startup.
  • Mojibake Prevention: Ensured that non-ASCII characters, such as accented names and CJK characters, are rendered correctly in API responses by overriding the default CP-1252 codepage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fix for Windows environments to force UTF-8 console output, preventing CP-1252 mojibake of non-ASCII characters. This is achieved by calling the Windows API function SetConsoleOutputCP with the UTF-8 code page (65001) in main.rs. Additionally, a changeset file is added to document this patch. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-ASCII characters in API responses are mangled on Windows when the console codepage is CP-1252 (default)

2 participants