fix(windows): force UTF-8 console codepage to prevent non-ASCII mojibake#825
Conversation
🦋 Changeset detectedLatest commit: 8978279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where non-ASCII characters are incorrectly displayed in the console on Windows systems. By explicitly setting the console output code page to UTF-8 during initialization, the application ensures consistent character rendering across different environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for Windows environments to force UTF-8 console output, preventing CP-1252 mojibake of non-ASCII characters. This is achieved by calling the Windows API function SetConsoleOutputCP with the UTF-8 code page (65001) in main.rs. Additionally, a changeset file is added to document this patch. There are no review comments, and I have no feedback to provide.
Summary
On Windows, the default console codepage is CP-1252 (or the system OEM codepage), which mangles non-ASCII characters (e.g. accented names, CJK characters) in API responses.
This change calls
SetConsoleOutputCP(65001)at startup when running on Windows, forcing the console to interpret output as UTF-8.Fixes #742
Checklist
cargo fmt --allpassedcargo clippy -- -D warningspassedcargo testpassedextern "system"FFI