Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated release of the @googleworkspace/cli package, incrementing its version to 0.13.3. The release incorporates a critical documentation fix that corrects flag names in various recipes, ensuring accuracy for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated release for version 0.13.3. While the version bumps and changelog generation are mechanically correct, there is a critical issue. The changelog claims to include a fix for incorrect flag names in documentation recipes (commit 8fce003). However, a review of the registry/recipes.yaml file on this branch shows that the incorrect flags are still in use. This suggests the fix is missing from the release branch. This release should be halted until the underlying code fix is correctly integrated.
|
|
||
| ### Patch Changes | ||
|
|
||
| - 8fce003: fix(docs): correct flag names in recipes (--spreadsheet-id, --attendees, --duration) |
There was a problem hiding this comment.
This changelog entry states that flag names in recipes have been corrected. However, the registry/recipes.yaml file in this branch still appears to contain the incorrect flags.
Specifically, the commit message mentions correcting flags to --spreadsheet-id, --attendees, and --duration. However, the recipes file still uses:
--spreadsheetinstead of--spreadsheet-id(e.g., in thecreate-expense-trackerrecipe).--attendeeinstead of--attendees(e.g., in thefind-free-timerecipe).--endinstead of--duration(e.g., in thefind-free-timerecipe).
This indicates that the fix from commit 8fce003 is not actually included in this release branch. Merging this PR would result in a release that claims a fix which is not present. This PR should not be merged until the fix is properly included.
|
/gemini review |
493d1f0 to
dda028b
Compare
There was a problem hiding this comment.
Code Review
This pull request primarily handles a version bump and fixes several incorrect flag names in the recipe documentation, such as changing --spreadsheet-id to --spreadsheet. The changes align with the command implementations.
During the review, I found that several recipes for gws sheets +append incorrectly use the --values flag with a JSON string, which will lead to parsing errors. I've left specific comments suggesting a fix to use the --json-values flag instead.
Additionally, there appears to be a more fundamental issue in src/helpers/sheets.rs where the implementation of --json-values incorrectly flattens multi-row data into a single row. This contradicts the documentation for bulk multi-row inserts. I recommend creating a follow-up issue to address this implementation bug to ensure the command works as expected for users.
I am having trouble creating individual review comments. Click here to see my feedback.
skills/recipe-create-expense-tracker/SKILL.md (23-24)
The examples for gws sheets +append incorrectly use the --values flag with a JSON array string. The implementation expects a comma-separated string for --values, which will cause incorrect parsing of the provided JSON. To pass a JSON array, the --json-values flag should be used instead. Please update the examples for correctness.
2. Add headers: `gws sheets +append --spreadsheet SHEET_ID --range 'Sheet1' --json-values '["Date", "Category", "Description", "Amount"]'`
3. Add first entry: `gws sheets +append --spreadsheet SHEET_ID --range 'Sheet1' --json-values '["2025-01-15", "Travel", "Flight to NYC", "450.00"]'`
skills/recipe-log-deal-update/SKILL.md (24)
The example for gws sheets +append incorrectly uses the --values flag with a JSON array string. The implementation expects a comma-separated string for --values, which will cause incorrect parsing of the provided JSON. To pass a JSON array, the --json-values flag should be used instead. Please update the example for correctness.
3. Append new row: `gws sheets +append --spreadsheet SHEET_ID --range 'Pipeline' --json-values '["2024-03-15", "Acme Corp", "Proposal Sent", "$50,000", "Q2", "jdoe"]'`
skills/recipe-sync-contacts-to-sheet/SKILL.md (23-24)
The examples for gws sheets +append incorrectly use the --values flag with a JSON array string. The implementation expects a comma-separated string for --values, which will cause incorrect parsing of the provided JSON. To pass a JSON array, the --json-values flag should be used instead. Please update the examples for correctness.
2. Create a sheet: `gws sheets +append --spreadsheet SHEET_ID --range 'Contacts' --json-values '["Name", "Email", "Phone"]'`
3. Append each contact row: `gws sheets +append --spreadsheet SHEET_ID --range 'Contacts' --json-values '["Jane Doe", "jane@company.com", "+1-555-0100"]'`
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request, generated by the Changesets release action, prepares for the v0.13.3 release. It primarily consists of version bumps in package.json, Cargo.toml, and Cargo.lock, along with an updated CHANGELOG.md. The changes also include several documentation fixes in the recipe files, correcting command-line flags to align with the implementation (e.g., --spreadsheet-id to --spreadsheet, --attendees to --attendee). The changes are correct and consistent with a standard release process.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/cli@0.13.3
Patch Changes