Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates the release of version Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is an automated release that bumps the package version to 0.13.0 and updates the changelog. While the versioning changes are correct, I've identified a documentation inconsistency introduced by one of the patches in this release. The guidance on shell quoting for Google Sheets ranges is now contradictory between README.md and skills/gws-shared/SKILL.md. I've added a comment to the CHANGELOG.md to highlight this issue, which should be addressed to avoid user confusion.
CHANGELOG.md
Outdated
| the `+` prefix convention, listing all 24 helper commands across 10 services | ||
| with descriptions and usage examples. | ||
|
|
||
| - e104106: Add shell tips section to gws-shared skill warning about zsh `!` history expansion, and replace single quotes with double quotes around sheet ranges containing `!` in recipes and skill examples |
There was a problem hiding this comment.
This change correctly notes the new recommendation to use double quotes for shell commands involving Google Sheets ranges with !. However, the main README.md file was not updated to reflect this. The 'Google Sheets — Shell Escaping' section in README.md (lines 275-287) still advises using single quotes, which contradicts the updated guidance in skills/gws-shared/SKILL.md and can cause issues for users on shells like zsh. To prevent user confusion, README.md should be updated to align with this new best practice.
There was a problem hiding this comment.
Code Review
This pull request is an automated release PR. The review focuses on the documentation changes for the new --html flag in several SKILL.md files. While the flag descriptions have been improved, several important tips regarding the usage and limitations of HTML emails have been removed. This includes a critical warning about broken inline images (cid: links), which constitutes a documentation regression. I've added comments to restore this valuable information for users.
I am having trouble creating individual review comments. Click here to see my feedback.
skills/gws-gmail-forward/SKILL.md (51-52)
The removal of these tips about using the --html flag appears to be a regression in the documentation. The information, especially about cid: references for inline images being broken, is a critical warning for users to prevent unexpected behavior and frustration. It would be best to restore these tips. If they were removed to avoid duplication, they should be moved to a shared document and referenced, but not removed entirely without a replacement.
skills/gws-gmail-reply-all/SKILL.md (58-59)
Similar to other documentation files in this PR, these tips about the --html flag have been removed. This information is valuable for users, especially the warning about broken inline images (cid:). Removing this is a documentation regression. Please consider restoring these tips.
skills/gws-gmail-reply/SKILL.md (52-53)
The tips regarding the --html flag, particularly the warning about broken inline images, have been removed. This is important information for the user and its removal degrades the documentation quality. Please consider re-adding these details.
skills/gws-gmail-send/SKILL.md (49)
This removed tip provides useful guidance on how to format HTML for the --body when using --html. It clarifies that only HTML fragments are needed, not a full document, which is a common point of confusion. Please consider restoring this helpful tip.
4dec6e0 to
e9f03f7
Compare
|
/gemini review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 66.02% 66.02%
=======================================
Files 38 38
Lines 16407 16407
=======================================
Hits 10832 10832
Misses 5575 5575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the @googleworkspace/cli and gws packages to version 0.13.1. Key changes include centralizing token cache filenames and adding ServiceAccount credential support, implementing auto-recovery for stale encrypted credentials, and providing shell tips for zsh history expansion while updating sheet range quoting in examples. Additionally, several Rust dependencies such as anstream, anstyle-parse, clap, clap_builder, clap_derive, and clap_lex have been updated to their latest versions.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/cli@0.13.1
Patch Changes
credentials.encand fall through to other credential sources (plaintext, ADC) instead of hard-erroring. Also sync encryption key file backup when keyring has key but file is missing.!history expansion, and replace single quotes with double quotes around sheet ranges containing!in recipes and skill examples