Repository navigation
feat!: raise minSdk to 24 and update android-maps-utils to 7.0.0 - #1073
Merged
Merged
Conversation
Raises androidMinSdk from 23 to 24 to match com.google.maps.android:android-maps-utils:7.0.0 (which exposes Maps SDK 20.1.0 requiring API 24), updates README.md to Android API level 24+, and bumps Gradle to 9.8.2, AGP to 9.5.0, Dependency Analysis to 3.20.1, Spotless to 8.11.0, and Ben Manes Versions to 0.67.0. BREAKING CHANGE: the minimum supported Android API level is now 24.
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
play-services-maps 20.1.0 (pulled in by android-maps-utils 7.0.0) initializes GoogleMapOptions.mapColorScheme to -1 instead of 0. GoogleMap() only applied its mapColorScheme when the options value was 0, so the scheme was silently dropped and the color scheme instrumentation tests failed. Compare against the SDK's own default (GoogleMapOptions().mapColorScheme) so both versions work, and an explicit LIGHT in googleMapOptionsFactory is now respected on 20.1.0. The lite mode tests expect that default instead of a hardcoded LIGHT.
Contributor
Coverage (instrumentation tests)
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
androidMinSdkfrom23to24to matchcom.google.maps.android:android-maps-utils:7.0.0(which exposes Maps SDK20.1.0requiring API 24).README.mdminimum requirement to Android API level 24+.com.google.maps.android:android-maps-utilsandcom.google.maps.android:android-maps-utils-coreto7.0.0.9.8.2, Android Gradle Plugin (agp) to9.5.0, Dependency Analysis plugin to3.20.1, Spotless to8.11.0, and Ben Manes Versions plugin to0.67.0.BREAKING CHANGE: the minimum supported Android API level is now 24.
Test Plan
./gradlew :maps-compose-widgets:testDebugUnitTest :maps-app:testDebugUnitTest :maps-app:compileDebugAndroidTestKotlin apiCheck spotlessCheck