Repository navigation
Conversation
…ests createComposeRule and createAndroidComposeRule from androidx.compose.ui.test.junit4 are deprecated in favour of the v2 versions, which run coroutines on StandardTestDispatcher. The Robolectric and device ScaleBar rendering tests already use v2.
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
Contributor
Coverage (instrumentation tests)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createComposeRuleandcreateAndroidComposeRulefromandroidx.compose.ui.test.junit4are deprecated in favour of theandroidx.compose.ui.test.junit4.v2versions. The v2 rules run coroutines onStandardTestDispatcherinstead ofUnconfinedTestDispatcher, so work is queued instead of running immediately, the same as a real dispatcher. This switches the nine instrumentation test files that still used the old rules;ScaleBarRenderingTests(Robolectric) andScaleBarDeviceRenderingTestsalready used v2.Only imports change:
GoogleMapFocusTraversalTests,GoogleMapViewClusteringTests,GoogleMapViewTests,MapInColumnTests,MapsInLazyColumnTest,RecompositionActivityTests,ScaleBarTests,StreetViewTestsandsmoke/DemoMenuNavigationTest. No test needed extra synchronization.Testing
maps-appinstrumentation tests compile with no deprecation warnings left for the test rules.:maps-app:connectedDebugAndroidTestwithrequireMapLoaded=trueon a Pixel 4 (Android 13): every migrated class passes, including the 28GoogleMapViewTests. The only failure wasDemoAppSmokeTestforMapsInLazyColumnActivity, which does not use the Compose test rule and is not touched here.Unable to resolve host "maps.googleapis.com"), so most map tests failed waiting for the map. CI runs both emulator suites on this PR.