Repository navigation
Conversation
maps-app used com.google.maps.android.compose, the same namespace and root package as maps-compose, which AGP 9 only allows with android.uniquePackageNames=false. Move the demo app, its tests and screenshot references to com.google.maps.android.compose.demo, add the explicit imports of the library classes it used implicitly through the shared package, and remove the flag. The applicationId stays com.google.maps.android.compose.
Coverage (unit tests)Compared against
Line and branch coverage from unit test reports. History is recorded on the |
Contributor
Coverage (instrumentation tests)
Files
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
chore: remove legacy AGP opt-out flags from gradle.properties(Base →main)chore/remove-legacy-agp-flags)Summary
maps-appusescom.google.maps.android.composeboth as namespace and as root package, the same asmaps-compose. AGP 9 rejects two modules with the same namespace, and we only build today because ofandroid.uniquePackageNames=false, the last legacy flag left after #1065. This moves the demo app tocom.google.maps.android.compose.demoand removes the flag.namespaceis nowcom.google.maps.android.compose.demo. TheapplicationIdstayscom.google.maps.android.compose, so the installed app, the CI workflows and the smoke tests keep targeting the same package.maps-appsources move to...compose.demo(main,test,androidTest,screenshotTest) together with the screenshot reference images. Git sees them as renames, so the history is kept.GoogleMap,Marker,rememberCameraPositionStateand friends without imports. They are now imported explicitly (no wildcards). A few files import both the Play services class and the composable with the same name (GoogleMap,Marker); Kotlin picks the right one from the call, same as before.demo-smoke-test.ymlandinstrumentation-test.yml, theinstallAndLaunchtask, AGENTS.md and the README/docs links to the demo sources.No change for the published libraries: only
maps-appand the build configuration are touched.This also helps #1063: the demo classes will not share a package with
maps-composeanymore, so the baseline profile filter becomes much simpler. Whichever of the two merges second needs a small update (the demo activity names inBaselineProfileGeneratorgain thedemo.prefix).Testing
./gradlew build koverXmlReportDebug(compile, unit tests, lint) passes.assembleDebugAndroidTestformaps-appandmaps-compose-widgets,:maps-app:validateDebugScreenshotTest(same reference images, moved) and:maps-app:assembleReleasepass.spotlessKotlinCheckis clean for the changed files (the "could not resolve all violations" warning onMarkerClusteringActivity.ktis already onmain).