Repository navigation
feat(settings): unify 3D quick settings widget and dedicated UI controls showcase - #78
Merged
Merged
Conversation
dkhawk
marked this pull request as ready for review
October 9, 2026 17:24
dkhawk
force-pushed
the
feat/quick-settings-widget
branch
from
October 12, 2026 18:42
703d017 to
4c09a61
Compare
LoyalAbbas
force-pushed
the
feat/quick-settings-widget
branch
from
October 14, 2026 12:55
703d017 to
d9ad649
Compare
LoyalAbbas
added this pull request to stack #82
October 14, 2026 12:55
dkhawk
added a commit
that referenced
this pull request
Oct 14, 2026
…ols showcase Consolidates the stacked 3D Maps camera UI control improvements (PR #78, PR #79, and PR #80) into a single cohesive branch with 100% 3-way parity across Kotlin Views, Java Views, and Jetpack Compose. - Quick Settings Overlay: Map3DQuickSettingsButton (Views) and Map3DQuickSettingsWidget (Compose) with session-scoped Map3DSettingsController. - Dedicated UI Controls Showcase: Introduces UiControlsActivity across Kotlin, Java, and Compose calling the Maps 3D SDK directly (getUiControlSettings().setUiControlsPlacement(...)) with local UI state. - SDK Standards: Removed internal reflection hacks into GoogleMap3D and LinearLayout layout mutations; standardized on ControlPlacement and ControlOrientation.VERTICAL. - Stability & Robustness: Prevents Compose NoSuchFieldError on stripped fields, fixes top control clipping under toolbars, and adds comprehensive JVM unit tests in Map3DSettingsControllerTest.
dkhawk
changed the title
… toggle - Introduce Map3DQuickSettingsButton for Kotlin and Java Views - Introduce Map3DQuickSettingsWidget for Jetpack Compose - Support live switching of Map Mode (Satellite, Hybrid, Roadmap) - Support live switching of Color Scheme (System, Light, Dark) - Support master and granular toggling of Maps 3D camera UI controls - Protect top camera controls and settings FAB from status bar insets - Add Map3DSettingsControllerTest with 100% passing JVM unit tests
…dget and fix GoogleMap3D syntax
…liably across Kotlin, Java, and Compose
…ols showcase Consolidates the stacked 3D Maps camera UI control improvements (PR #78, PR #79, and PR #80) into a single cohesive branch with 100% 3-way parity across Kotlin Views, Java Views, and Jetpack Compose. - Quick Settings Overlay: Map3DQuickSettingsButton (Views) and Map3DQuickSettingsWidget (Compose) with session-scoped Map3DSettingsController. - Dedicated UI Controls Showcase: Introduces UiControlsActivity across Kotlin, Java, and Compose calling the Maps 3D SDK directly (getUiControlSettings().setUiControlsPlacement(...)) with local UI state. - SDK Standards: Removed internal reflection hacks into GoogleMap3D and LinearLayout layout mutations; standardized on ControlPlacement and ControlOrientation.VERTICAL. - Stability & Robustness: Prevents Compose NoSuchFieldError on stripped fields, fixes top control clipping under toolbars, and adds comprehensive JVM unit tests in Map3DSettingsControllerTest.
dkhawk
force-pushed
the
feat/quick-settings-widget
branch
from
October 14, 2026 15:55
fe969d9 to
470f0f6
Compare
This was referenced Oct 14, 2026
…FieldError ()
- Add root compose_stability.conf treating com.google.android.gms.maps3d.** as stable
- Configure composeCompiler { stabilityConfigurationFiles } in ComposeDemos, common, and maps3d-compose
- Update DisposableEffect key in GoogleMap3D to boolean condition to avoid synthetic field lookups
- Apply spotless formatting across compose modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the stacked 3D Maps camera UI control improvements (PR #78, PR #79, and PR #80) into a single cohesive branch with 100% 3-way parity across Kotlin Views, Java Views, and Jetpack Compose. This supersedes PR #79 and PR #80.
Key Changes
1. Dedicated UI Controls Showcase (
UiControlsActivity)googleMap3D.getUiControlSettings()?.setUiControlsPlacement(...)) rather than routing through sample helper controllers.2. Quick Settings Overlay (
Map3DQuickSettingsButton&Map3DQuickSettingsWidget)Map3DSettingsControllerwith full JVM unit test coverage.3. Review Comments Addressed & Cleanups
resolveMapView(googleMap3D)reflection and internalLinearLayoutmutations (offsetTopControlContainers).UiControlsPlacementPositionalias with SDK canonicalControlPlacementeverywhere; standardized onControlOrientation.VERTICAL.attachMapacross all activities.NoSuchFieldError: No field $stablecrash on strippedMap3DView.$stablein Kotlin 2.x Compose compiler.Map3DViewdimensions to0dp(match_constraint) inactivity_hello_map.xmlandactivity_camera_controls.xml.TrackedMap3Dagainst duplicates and adoptedview.isVisible.Testing & Verification
./gradlew :Maps3DSamples:ApiDemos:common:testDebugUnitTest -Puse_local_maven=true(PASSED):kotlin-app,:java-app,:ComposeDemos:app,:snippets:kotlin-app,:snippets:java-app(ALL PASSED)./gradlew spotlessApply(PASSED)