feat: Resumable Media Upload functionality implementation - #72
Open
viacheslav-rostovtsev wants to merge 11 commits into
Open
viacheslav-rostovtsev wants to merge 11 commits into
viacheslav-rostovtsev wants to merge 11 commits into
Conversation
Public API `Gapic::Rest::ResumableUpload::Session` is the entry point. `Session#run` for initial upload, and `Session#resume` for resuming after error. Also public: `Progress`, `ResumeHandle`, `HasResumeHandle` module, and a typed error hierarchy. Changes to existing files: * `StubLogger#warn` * request-payload abridging in `ClientStub` so that binary upload bodies don't land in logs * `REST_ERROR_PREFIX` constant extracted in Rest::Error Integration testing against Showcase, for manual confirmation (disabled in CI). CI integration tests are planned to land in the generator.
…rim public surface
…replacement Show the coordinator alongside the driver in the architecture and test-plan diagrams.
…ble in driver_test Replaces the core.instance_variable_set poke with a Core double passed through the designed test seam.
…ries from it Comparing readers against a pristine policy dropped a caller's setting whenever it happened to equal the library default. #overrides reports only what was explicitly supplied, so start_retry_policy_for collapses to a merge and BACKOFF_DEFAULTS goes away.
…retry predicate Only the call timeout is now imposed unconditionally; every other setting the caller carries, including a retry predicate, reaches the initiation policy.
…ator A Showcase test that builds a Driver by hand exercises a path no generated client takes. All five suites now drive ::Gapic::ResumableUpload, build_config is gone, and the golden path gains a decode-into-a-message case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumable Media Upload functionality
Public API
Gapic::Rest::ResumableUpload::Sessionis the entry point.Session#startfor initial upload, andSession#resumefor resuming after error.Also public:
Progress,ResumeHandle,HasResumeHandlemodule, and a typed error hierarchy.Changes to existing files:
StubLogger#warnClientStubso that binary upload bodies don't land in logsREST_ERROR_PREFIXconstant extracted in Rest::ErrorIntegration testing