Skip to content

fix: guard aclose() against missing attributes during GC #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunhwan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: guard aclose() against missing attributes during GC #2243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16b6df8
fix: guard aclose() against missing attributes during GC
sunhwan Apr 7, 2026
22ee573
fix: add type ignore comment for mypy union-attr error
sunhwan Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions google/genai/_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2096,10 +2096,11 @@ async def aclose(self) -> None:
"""Closes the API async client."""
# Let users close the custom client explicitly by themselves. Otherwise,
# close the client when the object is garbage collected.
if not self._http_options.httpx_async_client:
http_options = getattr(self, '_http_options', None)
if http_options and not http_options.httpx_async_client and getattr(self, '_async_httpx_client', None):
await self._async_httpx_client.aclose() # type: ignore[union-attr]
if self._aiohttp_session and not self._http_options.aiohttp_client:
await self._aiohttp_session.close()
if getattr(self, '_aiohttp_session', None) and http_options and not http_options.aiohttp_client:
await self._aiohttp_session.close() # type: ignore[union-attr]

def __del__(self) -> None:
"""Closes the API client when the object is garbage collected.
Expand Down
Loading