Skip to content

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Dec 30, 2025

  • Support picosecond in Client.load_table_from_file()
  • Support picosecond in Client.list_rows()

@Linchin Linchin requested a review from a team as a code owner December 30, 2025 22:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Linchin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new capability into the BigQuery client library, allowing for precise control over timestamp data during table load operations. By introducing the timestamp_target_precision property, users can now define the subsecond precision for TIMESTAMP columns, including support for picoseconds, ensuring that time-sensitive data is accurately handled and stored when using autodetection, especially for CSV data sources.

Highlights

  • New Feature: Timestamp Target Precision: Introduced a new timestamp_target_precision property to the LoadJob class, allowing users to specify the desired precision for TIMESTAMP types during BigQuery table loading with autodetection.
  • Picosecond Timestamp Support: This enhancement enables the handling of picosecond-level timestamp data (up to 12 digits of subseconds), providing more granular control over timestamp interpretation, particularly for CSV-formatted data.
  • Comprehensive Unit Tests: Added a suite of unit tests to test_load_config.py to ensure the correct functionality of the timestamp_target_precision property, covering its getter, setter, and proper serialization/deserialization with API representations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for timestamp_target_precision in LoadJobConfig, which allows specifying target precisions for TIMESTAMP types during data loading with autodetection. The implementation looks good and is well-tested.

For future improvement and API consistency, consider exposing this new property on the LoadJob class as well, similar to how other LoadJobConfig properties are exposed. This would involve adding a corresponding read-only property to LoadJob that delegates to self.configuration.timestamp_target_precision.

I've also left a minor comment about a style issue in the docstring.

@Linchin Linchin changed the title feat: support load table with picosecond timestamp feat: support load_table and list_rows with picosecond timestamp Dec 31, 2025
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 31, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 31, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants