Conversation
product-auto-label
bot
added
size: m
chelsea-lin
reviewed
Feb 20, 2026
| @scalar_op_compiler.register_unary_op(ops.ToDatetimeOp, pass_op=True) | ||
| def to_datetime_op_impl(x: ibis_types.Value, op: ops.ToDatetimeOp): | ||
| if x.type() == ibis_dtypes.str: | ||
| if x.type() in (ibis_dtypes.str, ibis_dtypes.Timestamp("UTC")): # type: ignore |
Contributor
There was a problem hiding this comment.
Could you verify if the SQLGlot compiler requires similar handling? If it does, please enable bpd.options.experiments.sql_compiler = "experimental" and run the doc tests below. Thanks!
Contributor
Author
There was a problem hiding this comment.
Good catch!! I forgot to update the SQLGlot compiler.
Contributor
Author
There was a problem hiding this comment.
Could you verify if the SQLGlot compiler requires similar handling? If it does, please enable
bpd.options.experiments.sql_compiler = "experimental"and run the doc tests below. Thanks!
Updated the SQLGlot compiler and added tests. Also tested the code manually.
chelsea-lin
approved these changes
Feb 20, 2026
Contributor
Author
|
The notebook and sample test failures are related to multi-modals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
Noneand"UTC"time zones are supported in this version.Fixes b/481069646 🦕