fix: GenAI SDK client(multimodal) - Change "name" parameters to refer to resource name instead of dataset ID.#6569
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
fix: GenAI SDK client(multimodal) - Change "name" parameters to refer to resource name instead of dataset ID.#6569copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
650793c to
6f8f263
Compare
… to resource name instead of dataset ID. BREAKING CHANGE: Methods for multimodal datasets now require the full resource name instead of just the dataset ID. Affected methods: - `get_multimodal_dataset(name=...)` - `delete_multimodal_dataset(name=...)` - `update_multimodal_dataset(name=...)` - `assemble(name=...)` - `assess_*` methods (`dataset_name=...`) Example: Before: `client.datasets.get_multimodal_dataset(name="1234567890")` After: `client.datasets.get_multimodal_dataset(name="projects/my-project/locations/us-central1/datasets/1234567890")` PiperOrigin-RevId: 896997282
6f8f263 to
0989e4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: GenAI SDK client(multimodal) - Change "name" parameters to refer to resource name instead of dataset ID.
BREAKING CHANGE: Methods for multimodal datasets now require the full resource name instead of just the dataset ID.
Affected methods:
get_multimodal_dataset(name=...)delete_multimodal_dataset(name=...)update_multimodal_dataset(name=...)assemble(name=...)assess_*methods (dataset_name=...)Example:
Before:
client.datasets.get_multimodal_dataset(name="1234567890")After:
client.datasets.get_multimodal_dataset(name="projects/my-project/locations/us-central1/datasets/1234567890")