Skip to content

fix(jdbc): avoid String.format in log calls #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logachev merged 4 commits into from
Feb 6, 2026
Merged

fix(jdbc): avoid String.format in log calls #4096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e328129
fix: avoid String.format in log calls
logachev Feb 5, 2026
cb6949b
lint
logachev Feb 5, 2026
c363700
Merge branch 'main' into kirl/format_logging
logachev Feb 5, 2026
819fe08
Add missing logger entries
logachev Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryArrowResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ private String formatRangeElement(Object element, StandardSQLTypeName elementTyp

@Override
public void close() {
LOG.fine(String.format("Closing BigqueryArrowResultSet %s.", this));
LOG.fine("Closing BigqueryArrowResultSet %s.", this);
this.isClosed = true;
if (ownedThread != null && !ownedThread.isInterrupted()) {
// interrupt the producer thread when result set is closed
Expand Down
3 changes: 1 addition & 2 deletions ...oud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ public void close() {
statement.close();
}
} catch (SQLException ex) {
LOG.warning(
String.format("Exception during ResultState.close() operation: %s", ex.getMessage()));
LOG.warning("Exception during ResultState.close() operation: %s", ex.getMessage());
}
}

Expand Down
23 changes: 8 additions & 15 deletions ...bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryCallableStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,8 +930,7 @@ public URL getURL(String arg0) throws SQLException {
@Override
public void registerOutParameter(int paramIndex, int sqlType) throws SQLException {
LOG.finest("++enter++");
LOG.finest(
String.format("registerOutParameter: paramIndex %s, sqlType %s", paramIndex, sqlType));
LOG.finest("registerOutParameter: paramIndex %s, sqlType %s", paramIndex, sqlType);
checkClosed();
try {
this.parameterHandler.setParameter(
Expand All @@ -948,7 +947,7 @@ public void registerOutParameter(int paramIndex, int sqlType) throws SQLExceptio
@Override
public void registerOutParameter(String paramName, int sqlType) throws SQLException {
LOG.finest("++enter++");
LOG.finest(String.format("registerOutParameter: paramName %s, sqlType %s", paramName, sqlType));
LOG.finest("registerOutParameter: paramName %s, sqlType %s", paramName, sqlType);
checkClosed();
try {
this.parameterHandler.setParameter(
Expand All @@ -966,9 +965,7 @@ public void registerOutParameter(String paramName, int sqlType) throws SQLExcept
public void registerOutParameter(int paramIndex, int sqlType, int scale) throws SQLException {
LOG.finest("++enter++");
LOG.finest(
String.format(
"registerOutParameter: paramIndex %s, sqlType %s, scale %s",
paramIndex, sqlType, scale));
"registerOutParameter: paramIndex %s, sqlType %s, scale %s", paramIndex, sqlType, scale);
checkClosed();
if (sqlType != Types.NUMERIC && sqlType != Types.DECIMAL) {
throw new IllegalArgumentException(
Expand All @@ -991,9 +988,8 @@ public void registerOutParameter(int paramIndex, int sqlType, String typeName)
throws SQLException {
LOG.finest("++enter++");
LOG.finest(
String.format(
"registerOutParameter: paramIndex %s, sqlType %s, typeName %s",
paramIndex, sqlType, typeName));
"registerOutParameter: paramIndex %s, sqlType %s, typeName %s",
paramIndex, sqlType, typeName);
// fully qualified sql typeName is not supported by the driver and hence ignored.
registerOutParameter(paramIndex, sqlType);
}
Expand All @@ -1002,9 +998,7 @@ public void registerOutParameter(int paramIndex, int sqlType, String typeName)
public void registerOutParameter(String paramName, int sqlType, int scale) throws SQLException {
LOG.finest("++enter++");
LOG.finest(
String.format(
"registerOutParameter: paramIndex %s, sqlType %s, scale %s",
paramName, sqlType, scale));
"registerOutParameter: paramIndex %s, sqlType %s, scale %s", paramName, sqlType, scale);
checkClosed();
if (sqlType != Types.NUMERIC && sqlType != Types.DECIMAL) {
throw new IllegalArgumentException(
Expand All @@ -1027,9 +1021,8 @@ public void registerOutParameter(String paramName, int sqlType, String typeName)
throws SQLException {
LOG.finest("++enter++");
LOG.finest(
String.format(
"registerOutParameter: paramIndex %s, sqlType %s, typeName %s",
paramName, sqlType, typeName));
"registerOutParameter: paramIndex %s, sqlType %s, typeName %s",
paramName, sqlType, typeName);
// fully qualified sql typeName is not supported by the driver and hence ignored.
registerOutParameter(paramName, sqlType);
}
Expand Down
8 changes: 4 additions & 4 deletions ...-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ HeaderProvider createHeaderProvider() {
}

protected void addOpenStatements(Statement statement) {
LOG.finest(String.format("Statement %s added to Connection %s.", statement, this));
LOG.finest("Statement %s added to Connection %s.", statement, this);
this.openStatements.add(statement);
}

Expand Down Expand Up @@ -459,7 +459,7 @@ String getConnectionUrl() {
public Statement createStatement() throws SQLException {
checkClosed();
BigQueryStatement currentStatement = new BigQueryStatement(this);
LOG.fine(String.format("Statement %s created.", currentStatement));
LOG.fine("Statement %s created.", currentStatement);
addOpenStatements(currentStatement);
return currentStatement;
}
Expand Down Expand Up @@ -518,7 +518,7 @@ public Statement createStatement(
public PreparedStatement prepareStatement(String sql) throws SQLException {
checkClosed();
PreparedStatement currentStatement = new BigQueryPreparedStatement(this, sql);
LOG.fine(String.format("Prepared Statement %s created.", currentStatement));
LOG.fine("Prepared Statement %s created.", currentStatement);
addOpenStatements(currentStatement);
return currentStatement;
}
Expand Down Expand Up @@ -1175,7 +1175,7 @@ private void commitTransaction() {
public CallableStatement prepareCall(String sql) throws SQLException {
checkClosed();
CallableStatement currentStatement = new BigQueryCallableStatement(this, sql);
LOG.fine(String.format("Callable Statement %s created.", currentStatement));
LOG.fine("Callable Statement %s created.", currentStatement);
addOpenStatements(currentStatement);
return currentStatement;
}
Expand Down
Loading
Loading