Skip to content

chore(bigtable): modernize test to 1-node production instance #36560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(bigtable): modernize test to 1-node production instance #36560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions google-cloud-bigtable/acceptance/bigtable/project_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,24 +18,23 @@
require "bigtable_helper"

describe Google::Cloud::Bigtable::Project, :bigtable do
let(:instance_id_development) { "google-cloud-ruby-tests-dev" }
let(:cluster_id_development) { "ruby-clstr-dev" }
let(:instance_id) { "ruby-test-#{random_str}" }
let(:cluster_id) { "ruby-clstr-#{random_str}" }
let(:cluster_location) { "us-east1-b" }

after do
instance = bigtable.instance(instance_id_development)
instance.delete if instance
instance = bigtable.instance instance_id
instance&.delete
end

it "creates an instance with type development" do
it "creates an instance with type production" do
job = bigtable.create_instance(
instance_id_development,
instance_id,
display_name: "Ruby Acceptance Test",
type: :DEVELOPMENT,
type: :PRODUCTION,
labels: { env: "test" }
) do |clusters|
# "Need to have at least one cluster map element in CreateInstanceRequest."
clusters.add(cluster_id_development, cluster_location) # nodes not allowed
clusters.add cluster_id, cluster_location, nodes: 1
end

job.wait_until_done!
Expand All @@ -44,7 +43,7 @@

instance = job.instance
_(instance).must_be_kind_of Google::Cloud::Bigtable::Instance
_(instance.development?).must_equal true
_(instance.production?).must_equal true
_(instance.clusters.count).must_equal 1
cluster = instance.clusters.first

Expand Down
Loading