fix: onboard google-cloud-asset-v1 to Librarian - #35014
Open
suztomo wants to merge 3 commits into
Open
Conversation
suztomo
force-pushed
the
demo-generate-asset-v1
branch
2 times, most recently
from
July 24, 2026 13:25
aef5135 to
032bb83
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 24, 2026 13:50
032bb83 to
ce14b85
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 24, 2026 17:05
ce14b85 to
377e6f4
Compare
This was referenced Jul 27, 2026
Open
suztomo
force-pushed
the
demo-generate-asset-v1
branch
3 times, most recently
from
July 29, 2026 00:31
c29d4fc to
c96d15a
Compare
JoeWang1127
reviewed
Jul 29, 2026
suztomo
force-pushed
the
demo-generate-asset-v1
branch
3 times, most recently
from
July 29, 2026 23:26
1dfb446 to
a2e4c47
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 30, 2026 00:00
a2e4c47 to
12f6e66
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
2 times, most recently
from
July 30, 2026 02:18
2d1f8dd to
9327c92
Compare
suztomo
force-pushed
the
demo-generate-asset-v1
branch
from
July 30, 2026 02:23
9327c92 to
23af5f5
Compare
suztomo
marked this pull request as ready for review
July 30, 2026 02:24
Member
Author
|
@aandreassa This pull request and #35034 are ready for your review and being merged. After |
Contributor
|
@suztomo @JoeWang1127 please wait on #35037 and #35038 in order to minimize the diffs. I already started working on it googleapis/ruby-common-tools#439 |
Member
Author
|
For this particular pull request of one API, I don't think you have to wait for the work to minimize the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration PR for
librarian generate google-cloud-asset-v1.Note: The
fix:prefix in the title (fix: onboard google-cloud-asset-v1 to Librarian) is used to add this library to the next Release Please pull request.Commits:
chore: add google-cloud-asset-v1 to librarian.yamlgoogle-cloud-asset-v1inlibrarian.yaml.additional_protos: [google/cloud/orgpolicy/v1/orgpolicy.proto]andruby_cloud_opts.chore: removing OwlBot-related files.OwlBot.yamland.owlbot-manifest.json.chore: regenerate the onboarded library using librarianlibrarian generate google-cloud-asset-v1(built from latestupstream/mainof Librarian &upstream/mainof google-cloud-ruby).Findings & Summary of Code Diff from
upstream/main:Removal of OwlBot-related files:
.OwlBot.yamland.owlbot-manifest.jsondeleted as OwlBot postprocessor is superseded by Librarian.Description Update in README.md:
"A metadata inventory service that allows you to view, monitor, and analyze all your GCP and Anthos assets across projects and services."to"The Cloud Asset API manages the history and inventory of Google Cloud resources.".maincame from a handwrittenruby_cloud_descriptionoverride in Bazel'sBUILD.bazel.librarian generatederivesruby-cloud-descriptiondirectly fromdocumentation.summaryincloudasset_v1.yaml(PR fix(internal/librarian/ruby): pass documentation summary as ruby-cloud-description option librarian#7105).Product Documentation Link Removal in README.md:
README.mdremoved the sectionSee also the Product Documentation (https://cloud.google.com/asset-inventory/).ruby-cloud-product-url=https://cloud.google.com/asset-inventory/inBUILD.bazel.librarian.yamldoes not passruby-cloud-product-url, nor ispublishing.documentation_uripresent incloudasset_v1.yaml.Copyright Year Update:
2026as expected.Protobuf Comments Update:
proto_docs/google/protobuf/timestamp.rbsource comments updated to reflectprotoc 33.2.Snippet File Permission Normalization:
100755to100644.File & Version Preservation:
keep:(lib/google/cloud/asset/v1/asset_service/helpers.rb,test/google/cloud/asset/v1/additional_paths_test.rb), as well asversion.rb,.repo-metadata.json, andCHANGELOG.md, are correctly preserved during regeneration.Kokoro - Presubmit/Samples failure: