Skip to content

fix: onboard google-cloud-asset-v1 to Librarian - #35014

Open
suztomo wants to merge 3 commits into
googleapis:mainfrom
suztomo:demo-generate-asset-v1
Open

fix: onboard google-cloud-asset-v1 to Librarian#35014
suztomo wants to merge 3 commits into
googleapis:mainfrom
suztomo:demo-generate-asset-v1

Conversation

@suztomo

@suztomo suztomo commented Jul 24, 2026

Copy link
Copy Markdown
Member

Demonstration PR for librarian generate google-cloud-asset-v1.

Note: The fix: prefix in the title (fix: onboard google-cloud-asset-v1 to Librarian) is used to add this library to the next Release Please pull request.

Commits:

  1. chore: add google-cloud-asset-v1 to librarian.yaml
    • Configures google-cloud-asset-v1 in librarian.yaml.
    • Includes additional_protos: [google/cloud/orgpolicy/v1/orgpolicy.proto] and ruby_cloud_opts.
  2. chore: removing OwlBot-related files
    • Removed .OwlBot.yaml and .owlbot-manifest.json.
  3. chore: regenerate the onboarded library using librarian
    • Generated client, protobuf, and gRPC files using librarian generate google-cloud-asset-v1 (built from latest upstream/main of Librarian & upstream/main of google-cloud-ruby).

Findings & Summary of Code Diff from upstream/main:

  • Removal of OwlBot-related files: .OwlBot.yaml and .owlbot-manifest.json deleted as OwlBot postprocessor is superseded by Librarian.

  • Description Update in README.md:

  • Product Documentation Link Removal in README.md:

    • README.md removed the section See also the Product Documentation (https://cloud.google.com/asset-inventory/).
    • Reason: The previous Bazel build passed ruby-cloud-product-url=https://cloud.google.com/asset-inventory/ in BUILD.bazel. librarian.yaml does not pass ruby-cloud-product-url, nor is publishing.documentation_uri present in cloudasset_v1.yaml.
  • Copyright Year Update:

    • Header copyright years in 70 generated files updated to 2026 as expected.
  • Protobuf Comments Update:

    • proto_docs/google/protobuf/timestamp.rb source comments updated to reflect protoc 33.2.
  • Snippet File Permission Normalization:

    • Snippet file permissions normalized from 100755 to 100644.
  • File & Version Preservation:

    • Pre-existing files in keep: (lib/google/cloud/asset/v1/asset_service/helpers.rb, test/google/cloud/asset/v1/additional_paths_test.rb), as well as version.rb, .repo-metadata.json, and CHANGELOG.md, are correctly preserved during regeneration.
  • Kokoro - Presubmit/Samples failure:

@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch 2 times, most recently from aef5135 to 032bb83 Compare July 24, 2026 13:25
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch from 032bb83 to ce14b85 Compare July 24, 2026 13:50
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch from ce14b85 to 377e6f4 Compare July 24, 2026 17:05
@aandreassa aandreassa added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2026
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch 3 times, most recently from c29d4fc to c96d15a Compare July 29, 2026 00:31
@suztomo suztomo changed the title feat: demonstrate librarian generate google-cloud-asset-v1 feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client) Jul 29, 2026
@suztomo suztomo changed the title feat: demonstrate librarian generate google-cloud-asset-v1 (versioned client) chore: demonstrate librarian generate google-cloud-asset-v1 (versioned client) Jul 29, 2026
Comment thread google-cloud-asset-v1/README.md Outdated
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch 3 times, most recently from 1dfb446 to a2e4c47 Compare July 29, 2026 23:26
@suztomo suztomo changed the title chore: demonstrate librarian generate google-cloud-asset-v1 (versioned client) fix: onboard google-cloud-asset-v1 to Librarian Jul 29, 2026
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch from a2e4c47 to 12f6e66 Compare July 30, 2026 00:00
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch 2 times, most recently from 2d1f8dd to 9327c92 Compare July 30, 2026 02:18
@suztomo
suztomo force-pushed the demo-generate-asset-v1 branch from 9327c92 to 23af5f5 Compare July 30, 2026 02:23
@suztomo
suztomo marked this pull request as ready for review July 30, 2026 02:24
@suztomo
suztomo requested review from a team and yoshi-approver as code owners July 30, 2026 02:25
@suztomo

suztomo commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@aandreassa This pull request and #35034 are ready for your review and being merged.

After librarian.yaml have the entries, we (Tomo/Joe) can work on setting up CI (googleapis/librarian#7135) and confirm the new "ruby-librarian" Release Please strategy (googleapis/release-please#2861).

@suztomo
suztomo requested a review from aandreassa July 30, 2026 02:34
@aandreassa

Copy link
Copy Markdown
Contributor

@suztomo @JoeWang1127 please wait on #35037 and #35038 in order to minimize the diffs.

I already started working on it googleapis/ruby-common-tools#439

@suztomo

suztomo commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

For this particular pull request of one API, I don't think you have to wait for the work to minimize the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants