Skip to content

tests: parallel batching for packages when running unit tests#17621

Draft
parthea wants to merge 11 commits into
mainfrom
ci-improvements-20260702
Draft

tests: parallel batching for packages when running unit tests#17621
parthea wants to merge 11 commits into
mainfrom
ci-improvements-20260702

Conversation

@parthea

@parthea parthea commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

A legacy bottleneck in the unit test presubmit causes a timeout/crash after 4.5 hours (log) when testing all packages. This is blocking PR #17585 (Python 3.15 testing for all packages).

This PR introduces dynamic parallel execution, dropping runtime from several hours to under 10 minutes.

Key Changes

  • Add TEST_ALL_PACKAGES variable: When set to true, it forces the workflow to discover and execute testing across all repository packages regardless of the git diff.

  • ci/run_conditional_tests.sh: Accepts optional explicit package paths to run to facilitate batching

  • Adds a discover-packages job to the GH action workflow to batch testing of packages based on a configurable BATCH_SIZE (default: 5). It respects the TEST_ALL_PACKAGES variable which toggles testing of all packages, vs only the ones that have a diff.

  • Parallel Execution: Splitting the workload across a dynamic matrix of runners. Coverage artifacts use unique index names to prevent overwrites.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates ci/run_conditional_tests.sh to allow passing specific package paths as optional arguments to run tests only on those directories, defaulting to the entire packages directory if no arguments are provided. The review feedback highlights two key improvements: first, making the check for the "packages" directory robust against trailing slashes (e.g., "packages/") by stripping them before comparison; second, replacing the fragile parsing of ls with safer, more idiomatic Bash globbing.

Comment thread ci/run_conditional_tests.sh Outdated
Comment thread ci/run_conditional_tests.sh Outdated
@parthea parthea force-pushed the ci-improvements-20260702 branch from e9b44e3 to f2ce4a0 Compare July 2, 2026 18:35
parthea and others added 5 commits July 2, 2026 14:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@parthea

parthea commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates ci/run_conditional_tests.sh to allow passing specific package paths as optional arguments to restrict testing to those directories, falling back to the default behavior of scanning the packages directory if no arguments are provided. The review feedback identifies two robustness issues: first, handling non-existent directory arguments by validating their existence and exiting early; second, preventing issues with unmatched glob patterns when a directory is empty by verifying that each resolved path actually exists before processing.

Comment thread ci/run_conditional_tests.sh Outdated
Comment thread ci/run_conditional_tests.sh
parthea and others added 4 commits July 2, 2026 14:45
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@parthea parthea force-pushed the ci-improvements-20260702 branch from 8f3ffeb to d3a042e Compare July 2, 2026 20:17
@parthea parthea force-pushed the ci-improvements-20260702 branch from 5170f35 to 4898748 Compare July 2, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant