fix: avoid views when querying BigLake tables from SQL cells#16562
Open
fix: avoid views when querying BigLake tables from SQL cells#16562
Conversation
Workaround for internal bug 493608478.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for 4-part BigLake/Iceberg table identifiers by ensuring all parts of the table ID are correctly split and quoted during SQL generation. It also implements a workaround in pyformat.py for BigLake tables, which currently cannot be used in views, by generating a subquery instead of a placeholder table reference. Feedback was provided regarding an inconsistency in index handling for these subqueries compared to other table types.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for internal bug 493608478.
Migrates googleapis/python-bigquery-dataframes#2545
🦕