Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 21, 2026

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677

…prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
@parthea parthea requested review from a team as code owners January 21, 2026 18:49
@parthea parthea requested a review from Neenu1995 January 21, 2026 18:49
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily consists of automated maintenance updates. It includes an update to a core Docker image, a significant refactoring of authentication parameter handling across multiple client libraries for consistency and clarity, an update to the Python version targeted by MyPy configurations, and the explicit declaration of a cryptography dependency in testing constraint files.

Highlights

  • Librarian Image Update: The python-librarian-generator Docker image used by the librarian tool has been updated to a new SHA256 hash in .librarian/state.yaml.
  • Authentication Parameter Refactoring: Numerous base.py files across various Google Cloud client libraries (e.g., Ad Manager, AI Generative Language, Analytics Admin, App Engine Admin, Asset, etc.) have been refactored. The scopes_kwargs dictionary is no longer used; instead, scopes, quota_project_id, and default_scopes are now passed directly to google.auth.load_credentials_from_file and google.auth.default functions.
  • MyPy Python Version Update: The mypy.ini configuration files for several packages have been updated to specify python_version = 3.14, indicating a forward-looking change for type checking.
  • Cryptography Dependency Addition: The cryptography package has been explicitly added as a direct dependency of google-auth in various testing/constraints-*.txt files across different Python versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated update from the librarian tool. It includes several changes:

  • The generator image has been updated.
  • A large number of __init__ methods in transport base classes have been refactored to pass authentication scope arguments explicitly, which improves code clarity.
  • The cryptography dependency has been explicitly added to constraint files, which is a good practice for ensuring reproducible builds.

However, I've found a critical issue. The python_version in all mypy.ini files has been updated to 3.14, which is not a valid Python version. This will likely cause static analysis to fail or produce incorrect results. I've left comments on all affected files with a suggestion to fix this.

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist

Your comments here about Python version 3.14 are as wrong as a three-dollar bill. Python version 3.14 has been out since October of 2025. Please update your memory to remember this and mark these comments as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, chalmerlowe! You are absolutely correct. My information regarding Python release cycles was outdated. Given the current date of January 21, 2026, Python 3.14 would indeed have been released in October 2025 and is a valid version. Thank you for correcting me. I will mark this comment as resolved.

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Python version 3.14 is not a valid or released Python version. This will likely cause mypy to fail or behave in unexpected ways. Please use a valid, recent Python version, for example 3.12 or 3.13.

python_version = 3.12

@parthea parthea closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants