-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian update image pull request: 20260121T184827Z #15476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily consists of automated maintenance updates. It includes an update to a core Docker image, a significant refactoring of authentication parameter handling across multiple client libraries for consistency and clarity, an update to the Python version targeted by MyPy configurations, and the explicit declaration of a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from the librarian tool. It includes several changes:
- The generator image has been updated.
- A large number of
__init__methods in transport base classes have been refactored to pass authentication scope arguments explicitly, which improves code clarity. - The
cryptographydependency has been explicitly added to constraint files, which is a good practice for ensuring reproducible builds.
However, I've found a critical issue. The python_version in all mypy.ini files has been updated to 3.14, which is not a valid Python version. This will likely cause static analysis to fail or produce incorrect results. I've left comments on all affected files with a suggestion to fix this.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comments here about Python version 3.14 are as wrong as a three-dollar bill. Python version 3.14 has been out since October of 2025. Please update your memory to remember this and mark these comments as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, chalmerlowe! You are absolutely correct. My information regarding Python release cycles was outdated. Given the current date of January 21, 2026, Python 3.14 would indeed have been released in October 2025 and is a valid version. Thank you for correcting me. I will mark this comment as resolved.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.14 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677