chore: librarian generate pull request: 20260121T084706Z #15472
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a comprehensive set of automated updates across several Google Cloud client libraries. It integrates new features for KMS, Network Connectivity, Cloud Run, Dialogflow CX, and Database Center, alongside crucial bug fixes and documentation improvements. The changes aim to enhance API capabilities and client library accuracy. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is an automated pull request that updates client libraries from new protobuf definitions. The changes introduce new features and clients for services like Database Center and Dialogflow CX. My review focuses on the correctness of the generated code, especially the new sample snippets. I've found several issues in the generated samples that would cause them to fail, a typo in a docstring, and some minor maintainability issues in __init__.py files. The sample code issues are critical as they would break for users copying them.
| # Initialize request argument(s) | ||
| example = dialogflowcx_v3.Example() | ||
| example.actions.user_utterance.text = "text_value" |
There was a problem hiding this comment.
The sample code for initializing example.actions is incorrect. actions is a repeated field of Action messages and does not have a user_utterance attribute. You should create an Action instance, populate it, and then append it to the actions list. This issue is also present in the update_example sample in this file.
For example:
action = dialogflowcx_v3.Action()
action.user_utterance.text = "text_value"
example.actions.append(action)| example.conversation_state = "OUTPUT_STATE_PENDING" | ||
| request = dialogflowcx_v3.UpdateExampleRequest( | ||
| example=example, |
There was a problem hiding this comment.
The sample code for initializing example.actions is incorrect. actions is a repeated field of Action messages and does not have a user_utterance attribute. You should create an Action instance, populate it, and then append it to the actions list.
For example:
action = dialogflowcx_v3.Action()
action.user_utterance.text = "text_value"
example.actions.append(action)| request = dialogflowcx_v3.CreateExampleRequest( | ||
| parent="parent_value", | ||
| example=example, |
There was a problem hiding this comment.
The sample code for initializing example.actions is incorrect. actions is a repeated field of Action messages and does not have a user_utterance attribute. You should create an Action instance, populate it, and then append it to the actions list. This issue is also present in the update_example sample in this file.
For example:
action = dialogflowcx_v3.Action()
action.user_utterance.text = "text_value"
example.actions.append(action)| request = dialogflowcx_v3.UpdateExampleRequest( | ||
| example=example, | ||
| ) |
There was a problem hiding this comment.
The sample code for initializing example.actions is incorrect. actions is a repeated field of Action messages and does not have a user_utterance attribute. You should create an Action instance, populate it, and then append it to the actions list.
For example:
action = dialogflowcx_v3.Action()
action.user_utterance.text = "text_value"
example.actions.append(action)| request = dialogflowcx_v3.CreatePlaybookVersionRequest( | ||
| parent="parent_value", | ||
| ) |
There was a problem hiding this comment.
The playbook_version field is required for this request but is not provided in the sample. This will cause a TypeError at runtime. Please add the playbook_version to the request initialization.
| request = dialogflowcx_v3.CreatePlaybookVersionRequest( | |
| parent="parent_value", | |
| ) | |
| playbook_version = dialogflowcx_v3.PlaybookVersion() | |
| request = dialogflowcx_v3.CreatePlaybookVersionRequest( | |
| parent="parent_value", | |
| playbook_version=playbook_version, | |
| ) |
|
|
||
|
|
||
| class IssueGroupStats(proto.Message): | ||
| r"""IssueGroupStats refers to stats for a particulare combination |
There was a problem hiding this comment.
There is a typo in the docstring. "particulare" should be "particular".
| r"""IssueGroupStats refers to stats for a particulare combination | |
| r"""IssueGroupStats refers to stats for a particular combination |
| "GetChangelogRequest", | ||
| "ListChangelogsRequest", | ||
| "ListChangelogsResponse", | ||
| "CodeBlock", |
There was a problem hiding this comment.
The __all__ list is not alphabetically sorted. The new entry CodeBlock is inserted here, but it should be placed in alphabetical order within the list for better maintainability. This issue is present for other new entries in this list as well.
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add the SingleTenantHsm functionality including the management API and resource types
PiperOrigin-RevId: 858582271
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@d9f058d2
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
crypto_key_backendin message.google.cloud.kms.v1.CryptoKeyis expanded to include SingleTenantHsmInstancesPiperOrigin-RevId: 858582271
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@d9f058d2
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for enum value
MODIFIED_GOOGLE_INITIATED_SYSTEM_OPERATIONin enumAccessReasonis changedPiperOrigin-RevId: 858582271
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@d9f058d2
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for enum value
MODIFIED_CUSTOMER_INITIATED_ACCESSin enumAccessReasonis changedPiperOrigin-RevId: 858582271
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@d9f058d2
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Added OUTPUT_ONLY annotations to create_time and update_time in InternalRange to reflect existing service behavior
PiperOrigin-RevId: 858089458
Library-IDs: google-cloud-network-connectivity
Source-link: googleapis/googleapis@cb268fbe
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: add instances description
PiperOrigin-RevId: 856756379
Library-IDs: google-cloud-run
Source-link: googleapis/googleapis@a79ccb6a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add instances client library
PiperOrigin-RevId: 856756379
Library-IDs: google-cloud-run
Source-link: googleapis/googleapis@a79ccb6a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
webhook_latenciesis removed from message.google.cloud.dialogflow.cx.v3.QueryResultPiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
webhook_display_namesis removed from message.google.cloud.dialogflow.cx.v3.QueryResultPiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
start_flowis moved in to oneof in message.google.cloud.dialogflow.cx.v3.AgentPiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: updated v3 dialogflow client libraries
PiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
webhook_idsis removed from message.google.cloud.dialogflow.cx.v3.QueryResultPiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
webhook_tagsis removed from message.google.cloud.dialogflow.cx.v3.QueryResultPiperOrigin-RevId: 856725401
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@b8d14913
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Adding Method AggregateIssueStats of Database Center API v1beta
This release includes:
DatabaseCenterservice withAggregateIssueStatsmethod.PiperOrigin-RevId: 856484579
Library-IDs: google-cloud-databasecenter
Source-link: googleapis/googleapis@615bb9ac
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@94aa4f5a
(exclusive) and
googleapis/googleapis@d9f058d2
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
Generation failed for