-
Notifications
You must be signed in to change notification settings - Fork 464
chore: Jwt migration to the monorepo #9690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hectorhammett
wants to merge
323
commits into
main
Choose a base branch
from
jwt-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,913
−19
Open
Changes from all commits
Commits
Show all changes
323 commits
Select commit
Hold shift + click to select a range
5c08222
Update to ./run-tests.sh
robertdimarco 265817f
Add'l updates to the ./run-tests.sh script
robertdimarco c37a2ef
Updates to JWT decode() / verify() path
robertdimarco bba6a69
Update decode() to require allowed algorithms arg when verifying
robertdimarco 556b8b4
Comment tweaks
robertdimarco e13d2af
A few additional tests for none algorithm and an incorrect algorithm
8c344df
Merge pull request firebase/php-jwt#35 from firebase/rd-verify-refactor
e1cac0c
Merge branch 'rd-verify-refactor' into cr-additional-tests
robertdimarco aa13abb
Update README to reflect newly-required algorithms arguments
robertdimarco 246462b
Add a few add'l tests
robertdimarco 079c5e4
Merge pull request firebase/php-jwt#36 from firebase/cr-additional-tests
robertdimarco 6ad3146
Bump version to 2.0.0
robertdimarco 5475935
Update composer.json
bf885bf
Add Changelog
robertdimarco 12367b4
Merge branch 'master' of github.com:firebase/php-jwt
robertdimarco 72565e6
Remove the useless target-dir setting from the composer config
stof ee4aac9
Provide a leeway time in the verification of timestamps to account fo…
41fe756
Merge pull request firebase/php-jwt#37 from stof/patch-1
robertdimarco 04a5724
Changed the leeway to be a static variable
25d9afc
Reverted some tests from first commit
800c397
Added tests with leeway value in nbf and iat
7b0d35c
Merge pull request firebase/php-jwt#46 from lcabral37/skew
robertdimarco e6436c2
Reset clock skew / leeway after relevant tests & update README
robertdimarco 7d4405b
Allow using \ArrayAccess as $key in decode
aztech-dev 5e2670f
Add tests for \ArrayAccess key chooser
6ad4366
Merge pull request firebase/php-jwt#48 from aztech-forks/master
robertdimarco 8f6f3cf
Merge pull request firebase/php-jwt#47 from firebase/rd-improve-test-…
9ffb6dd
Update README for v2.1.0 release
robertdimarco 23859f7
Update package.xml
robertdimarco 52eea26
Add badges for latest release, total downloads, and license
robertdimarco 673b065
Adding header options to add
mcocaro e3c3b96
Adding array_values only
mcocaro b8cc28f
Merging both arrays together
mcocaro d724caa
Assigning to header var merged array
mcocaro f5ba516
Adding test
mcocaro 442b593
Reversing array merge to avoid overwrites of default headers
mcocaro a8e3d56
Merge pull request firebase/php-jwt#53 from mcocaro/master
robertdimarco 3a3908b
Update README and bump to v2.2.0
robertdimarco 9f9742d
Add firespace\jwt namespace
b3ec84d
update example to use new namespace
d25a0c3
fix unexpectedvalueexceptions and add unit tests
e5c6748
Add composer.phar to gitignore
robertdimarco 81391cd
require a non-empty key to decode a JWT
sjones608 77ec79d
Merge pull request firebase/php-jwt#59 from Dashron/master
robertdimarco ce094ce
Aligned the DocBlocks
johanderuijter dfdb5c6
Merge pull request firebase/php-jwt#62 from johanderuijter/docblock
robertdimarco b7bbd9b
Merge remote-tracking branch 'upstream/master' into nullkey
sjones608 1a779fa
add use InvalidArgumentException to account for JWT namespace
sjones608 fb3b4db
Merge pull request firebase/php-jwt#60 from sjones608/nullkey
robertdimarco 743b249
Update package.xml and README.md for 3.0.0 release
robertdimarco c0ba03f
Update Travis to use their new container infrastructure
21552b8
Merge pull request firebase/php-jwt#66 from firebase/jw-travis-upgrade
robertdimarco 5a2f30e
Addresses issue firebase/php-jwt#72 - update link to current spec
robertdimarco 13357e5
Remove null as possible key value in docblock
akeeman dc498a1
[+]: ".gitattributes" <- prevent installing special files via composer
2873bd1
Allow timestamp to be specified rather than relying on PHP time() fun…
josephmcdermott 3b24091
Commit with Google email address for CLA
josephmcdermott 379364f
Remove newline at beginning of run-tests.sh
legoktm 5337f46
Merge pull request firebase/php-jwt#76 from akeeman/patch-1
robertdimarco f340689
Merge pull request firebase/php-jwt#96 from legoktm/patch-1
robertdimarco dcc66cb
Merge pull request firebase/php-jwt#93 from josephmcdermott/specify-c…
robertdimarco b913e3f
Merge pull request firebase/php-jwt#82 from voku/master
robertdimarco 11014c8
Fix exceptions classes (firebase/php-jwt#81)
Maks3w f332440
Add in support for late static binding, so that developers can extend…
chappy84 71cf43b
Update README for v4.0.0
robertdimarco 7e97921
Travis: run tests also under PHP 5.6 and PHP 7.0 (firebase/php-jwt#108)
petrkotek 3e42362
bugfix: 'kid' not in given key list
stampycode ed7f1aa
cosmetic updates
stampycode 5d3eed0
Support RS384 and RS512 (firebase/php-jwt#117)
joostfaassen 9250bcb
draft-ietf-oauth-json-web-token-06 --> rfc7519 (firebase/php-jwt#107)
akeeman 663ad5e
example for RS256 openssl (firebase/php-jwt#125)
HenryNe 84e50cd
Merge pull request firebase/php-jwt#129 from stampycode/patch-1
bshaffer c5b954b
Fixes travis, adds PHP 7.1, and removes HHVM (firebase/php-jwt#160)
bshaffer c86f391
Updates JWT::verify to handle openssl errors (firebase/php-jwt#159)
bshaffer f2eaa2f
removes minimum-stabity from composer.json (firebase/php-jwt#161)
bshaffer 1d79c5a
Add the proper Exception message for all JSON error types by PHP (fir…
gbalduzzi a8252d3
Detect invalid Base64 encoding in signature (firebase/php-jwt#162)
bshaffer ddf9d64
Add new line warning to README (firebase/php-jwt#115)
chinedufn c0a6aff
added `array` type hinting to `decode` method (firebase/php-jwt#101)
hywak 4ae2ae8
Remove outdated package.xml (firebase/php-jwt#165)
bshaffer da67b59
updates README changelog for v5.0.0 (firebase/php-jwt#166)
bshaffer 528460b
Adds PHP 7.2 to Travis (firebase/php-jwt#186)
bshaffer c9169e6
Adds ES256 to supported algorithms (firebase/php-jwt#239)
beamerblvd 67b6374
Fixes tests, adds PHP 7.3 (firebase/php-jwt#257)
bshaffer aa71cfb
Whitespace style fix (firebase/php-jwt#255)
Krisell 3ee9655
Comment typo fix (firebase/php-jwt#253)
stembrain 220e3c8
Clearer variable name in README (firebase/php-jwt#229)
glaand 2e56ca4
Use json_last_error without unnecessary existence check (firebase/php…
Krisell 1e51010
Add php 7.4 to travis (firebase/php-jwt#266)
723977a
docs: add resource type as 2nd param in decode method (firebase/php-j…
win0err 74054f7
tests: update PHPUnit test classes (firebase/php-jwt#193)
bshaffer 0dbbbdd
docs: fix missed param name (firebase/php-jwt#207)
rtm-ctrlz 660f473
feat: add support for ES256 algorithm (firebase/php-jwt#256)
bshaffer 9314c7a
fix: added keywords to composer.json (firebase/php-jwt#243) (firebase…
NiMeDia 7fd64f4
remove ignore_bit_strings (firebase/php-jwt#276)
bshaffer 75790fa
test: allow for later versions of phpunit (firebase/php-jwt#277)
phil-davis df1f3a9
feat: adds JWK support (firebase/php-jwt#273)
EricTendian 524201b
test: use keys for testing JWK (firebase/php-jwt#283)
bshaffer f56529b
chore: code cleanup (firebase/php-jwt#278)
phil-davis 4179ce0
chore: fixes cs and adds cs checking to travis (firebase/php-jwt#284)
bshaffer b4fd2d2
docs: add JWK usage to README (firebase/php-jwt#307)
bshaffer e7c0043
fix: add missing use statement in JWK (firebase/php-jwt#303)
pendenga 59aa36b
chore: add phpdoc @throws in JWT::decode (firebase/php-jwt#320)
bborrel d071f3a
chore: remove leading backslashes in imports (firebase/php-jwt#301)
kewlashu 2e5721a
chore: remove travis, add github actions (firebase/php-jwt#331)
bshaffer 2d72e3b
fix: allow for null d values in RSA JWK (firebase/php-jwt#330)
bshaffer b5b9022
chore(docs): clean up README (firebase/php-jwt#332)
bshaffer 31b45db
chore(tests): add php 5.3 test
bshaffer cf577af
chore(tests): fix entrypoint for php 5.3 (firebase/php-jwt#333)
bshaffer 9e5264c
chore: fix licence (firebase/php-jwt#329)
exussum12 838b481
feat: add ES384 support (firebase/php-jwt#324)
sdrsdr be83666
chore: test cleanup (firebase/php-jwt#334)
bshaffer fa16366
chore: add tests and docs for rsa with passphrase (firebase/php-jwt#335)
bshaffer 01914ff
feat: make parseKey public (firebase/php-jwt#337)
bshaffer ffb1fb8
chore: export-ignore github dir (firebase/php-jwt#338)
romainmenke 7835b2c
chore(tests): add rsa encode/decode (firebase/php-jwt#344)
bshaffer 82d5dd1
feat: add Ed25519 support to JWT (firebase/php-jwt#343)
pwolanin 8179c3f
chore: fix tests (firebase/php-jwt#366)
bshaffer 1da5f11
chore: add PHP 8.1 (firebase/php-jwt#362)
2824804
feat: add Key object to prevent key/algorithm type confusion (fireba…
bshaffer 47f2b98
chore: explicit third parameter to decode function in README
bshaffer 153be41
fix: phpdoc and exception (firebase/php-jwt#371)
bshaffer c85a9bd
chore(docs): add throws DomainException for JWT::decode (firebase/php…
dakujem 63e1cfc
chore: switch main to master (firebase/php-jwt#383)
bshaffer 7e50a6b
chore(docs): fix typo in README
bshaffer 648f483
feat!: require Key object, use JSON_UNESCAPED_SLASHES, remove constan…
bshaffer 289695e
chore: update changelog for v6.0.0 (firebase/php-jwt#391)
bshaffer 65b6739
feat!: update return type for JWK methods (firebase/php-jwt#392)
bshaffer 7fdfb5c
fix: correct order for hash_equals (firebase/php-jwt#393)
bshaffer 63c3d3f
fix: use property_exists for checking key id (firebase/php-jwt#395)
bshaffer 301e9ff
chore(docs): fix release URL in README (firebase/php-jwt#394)
makstech 6d3627b
feat: add typing, require PHP 8.0 (firebase/php-jwt#385)
bshaffer 17640df
chore: remove phpunit shim (firebase/php-jwt#401)
bshaffer 820340f
chore: add array casting to README (firebase/php-jwt#402)
bshaffer 13c2742
chore: add phpstan for static analysis (firebase/php-jwt#406)
bshaffer 4a8af8a
chore: update library to phpstan level 7 (firebase/php-jwt#407)
bshaffer 5d864d9
feat: add back compatibility for >= PHP 7.1 (firebase/php-jwt#405)
bshaffer b0b9a18
chore: add back timestamp var for compatibility (firebase/php-jwt#412)
bshaffer 197d908
chore: update CHANGELOG for v6.1.0
bshaffer 8fe9b54
chore: add missing docblock param for $alg (firebase/php-jwt#419)
berrugo 4e69c0b
fix: add flag to force object (firebase/php-jwt#416)
bshaffer 6058795
fix: revert add flag to force object (firebase/php-jwt#420)
bshaffer 2b1b862
chore: styles for short array and single quotes (firebase/php-jwt#423)
Krisell 57d6035
chore: add cs config, fix git-attributes, removed unused entrypoint.s…
bshaffer 31701d4
feat: add cached keyset (firebase/php-jwt#397)
bshaffer 46c516a
feat: add defaultAlg param (firebase/php-jwt#426)
bshaffer 91aa304
feat: Add ES256 support to JWK (firebase/php-jwt#399)
bshaffer 49fbdcc
chore: fix styles and phpstan (firebase/php-jwt#440)
bshaffer a2cae38
fix: cache jwks as string in CachedKeySet (firebase/php-jwt#435)
brandomeniconi 16118f4
chore: misc cleanup (firebase/php-jwt#439)
mehdihasanpour bd58d4b
chore: update changelog for v6.2.0 (firebase/php-jwt#434)
Tinywan 21c3fc1
chore: prepare v6.3.0 (firebase/php-jwt#441)
bshaffer 42df9fd
fix: casing of GET for PSR compat (firebase/php-jwt#451)
bshaffer b0e0d56
fix: string interpolation format for php 8.2 (firebase/php-jwt#446)
lvsantos1 77ec419
chore(docs): add examples for exception handling (firebase/php-jwt#463)
bshaffer 3864599
chore(docs): encode does not accept objects (firebase/php-jwt#457)
t-richard ded6e95
chore: add release-please (firebase/php-jwt#467)
bshaffer f5459a4
chore: move changelog into separate file (firebase/php-jwt#469)
bshaffer 4836b28
chore(main): release 6.3.1 (firebase/php-jwt#468)
release-please[bot] 2f9ec88
fix: check kid before using as array index
bshaffer cadbd65
chore(main): release 6.3.2 (firebase/php-jwt#470)
release-please[bot] 17d15f0
chore: add PHP 8.2 to test suite (firebase/php-jwt#476)
bshaffer 75f5feb
chore: suggest ext-sodium (firebase/php-jwt#474)
peter279k 462e3ec
feat: add support for W3C ES256K (firebase/php-jwt#462)
scrummitch 780bb8e
chore(tests): use assertSame for strict equals (firebase/php-jwt#478)
peter279k d9445ed
feat: improve caching by only decoding jwks when necessary (firebase/…
bshaffer f032b1d
chore(main): release 6.4.0 (firebase/php-jwt#477)
release-please[bot] a4f8a43
chore: fix RS256 example in README
akshaykhale1992 dc5424a
chore: add ArrayAccess to PHPDoc for JWT::decode (firebase/php-jwt#443)
ppaulis d85e8f7
chore(docs): add multiple keys example to README (firebase/php-jwt#503)
bshaffer ab23121
chore: skip null checks when input is never null (firebase/php-jwt#502)
sanmai f410eff
chore(docs): example of unsafe header decode in README (firebase/php-…
saranshdhingra 4d649d2
fix: Allow KID index 0
ajupazhamayil 9d9be02
fix: Allow KID index 0
ajupazhamayil 3dd3e19
fix: allow KID of '0' (firebase/php-jwt#505)
bshaffer a9ea806
chore: drop support for PHP 7.3 (firebase/php-jwt#495)
bshaffer f93f9f1
chore: release 6.5.0
bshaffer 8e55034
chore(main): release 6.5.0 (firebase/php-jwt#506)
release-please[bot] b630dab
chore(docs): add missing imports for example in README (firebase/php-…
SachinBahukhandi a58c197
fix: only check iat if nbf is not used (firebase/php-jwt#493)
croensch e2cc8b1
feat: allow get headers when decoding token (firebase/php-jwt#442)
kpn13 a12cd7e
chore: update README
bshaffer f4ff84f
chore(main): release 6.6.0 (firebase/php-jwt#511)
release-please[bot] 27d4232
feat: add ed25519 support to JWK (public keys) (firebase/php-jwt#452)
edudobay 318b4e6
chore(main): release 6.7.0 (firebase/php-jwt#518)
release-please[bot] 25081c3
fix: handle invalid http responses (firebase/php-jwt#508)
bshaffer c636c61
chore(tests): remove unused variable
bshaffer a8568fc
feat: add support for P-384 curve (firebase/php-jwt#515)
lleyton d72589a
chore(main): release 6.8.0 (firebase/php-jwt#519)
release-please[bot] 3bfd475
fix: accept float claims but round down to ignore them (firebase/php-…
croensch db79926
chore: add tests for latest fixes (firebase/php-jwt#512)
bshaffer d01db1c
chore: better BeforeValidException message for decode (firebase/php-j…
vishwarajanand 586a794
chore(main): release 6.8.1 (firebase/php-jwt#524)
release-please[bot] 2202a85
feat: add payload to jwt exception (firebase/php-jwt#521)
bshaffer 947ce99
chore(main): release 6.9.0 (firebase/php-jwt#537)
release-please[bot] b983af4
feat: allow typ header override (firebase/php-jwt#546)
bshaffer 1b29a2d
chore(main): release 6.10.0 (firebase/php-jwt#547)
release-please[bot] be4e73f
fix: fix ratelimit cache expiration (firebase/php-jwt#550)
bshaffer 8812222
chore: add php 8.3 to ci (firebase/php-jwt#548)
bshaffer 34a4196
chore: remove jwt incorrect key warning (firebase/php-jwt#560)
vishwarajanand 72d64bc
chore: drop support for PHP 7.4 (firebase/php-jwt#558)
bshaffer 076bf54
fix: ensure ratelimit expiry is set every time (firebase/php-jwt#556)
bshaffer a065638
chore(main): release 6.10.1 (firebase/php-jwt#551)
release-please[bot] eec1c7d
chore: add test for parseKey (firebase/php-jwt#565)
bshaffer 566a007
chore: Prepare towards PHP8.4 compatibility (firebase/php-jwt#572)
sbuerk 178857b
fix: support php 8.4 (firebase/php-jwt#583)
ruudk 5f47ab3
chore: fix phpstan (firebase/php-jwt#584)
bshaffer 0594ba7
chore(main): release 6.10.2 (firebase/php-jwt#585)
release-please[bot] 7cbdaa4
fix: refactor constructor Key to use PHP 8.0 syntax (firebase/php-jwt…
mark-burns-0 a287f1a
docs: fix example to avoid fatal error (firebase/php-jwt#590)
robocoder 90217b2
feat: support octet typed JWK (firebase/php-jwt#587)
apiwat-chantawibul b42d044
chore(main): release 6.11.0 (firebase/php-jwt#586)
release-please[bot] e9b88cf
docs: fix examples in README.md (firebase/php-jwt#569)
SySafarila ea0960b
fix: update error text for consistency (firebase/php-jwt#528)
fredden 6e2986f
chore(main): release 6.11.1 (firebase/php-jwt#597)
release-please[bot] 7779849
fix: use DateTime::ATOM instead of ISO8601 in exception message
ennorehling 39da250
fix: validate iat and nbf on payload (firebase/php-jwt#568)
christiandavilakoobin 9605c8d
chore: move release please from app to github action (firebase/php-jw…
bshaffer d4b4af4
feat: add SensitiveParameter attribute to security-critical parameter…
meihei3 01b598a
feat: store timestamp in `ExpiredException` (firebase/php-jwt#604)
cosmastech b90a694
chore: update release-please secret (firebase/php-jwt#608)
bshaffer 8441566
feat: add key size validation (firebase/php-jwt#613)
bshaffer 31caaf5
chore(main): release 7.0.0 (firebase/php-jwt#614)
bshaffer 2ec2405
Add key size validation (firebase/php-jwt#612)
bshaffer 48271b8
fix: add key length validation for ec keys (firebase/php-jwt#615)
bshaffer 05de0c7
chore(main): release 7.0.2 (firebase/php-jwt#616)
bshaffer 0c58d6e
docs: allow array of strings in head param (firebase/php-jwt#599)
bshaffer e0a44be
chore: add PHP 8.5 to testing matrix (firebase/php-jwt#617)
bshaffer 8b722fc
chore: add environment for Release Please job (firebase/php-jwt#619)
bshaffer 7335cc8
chore(main): release 7.0.3 (firebase/php-jwt#622)
bshaffer 69e0af0
fix: readme examples, add tests for all examples (firebase/php-jwt#626)
bshaffer ba4b201
fix: use urlsafeB64Decode everywhere (firebase/php-jwt#627)
bshaffer 3c5d273
chore(main): release 7.0.4 (firebase/php-jwt#629)
bshaffer 750b6cc
fix: RSA from JWK sometimes returns empty Instance (firebase/php-jwt#…
NReib a304572
chore(main): release 7.0.5 (firebase/php-jwt#630)
bshaffer 965be24
chore: add tests for JWK ASN1 fix (firebase/php-jwt#631)
bshaffer dc588cf
chore: fix ReadmeTest (firebase/php-jwt#636)
bshaffer 0370908
fix: validate numeric type of iat, nbf and exp claims in encode (fire…
guillaumedelre 9f06bc9
Fix: Update homepage URL in composer.json (firebase/php-jwt#635)
glensc f64bcb7
fix: skip parsing valid unsupported curves (firebase/php-jwt#638)
bshaffer 8105e70
feat: Add support for PS256 (firebase/php-jwt#637)
Hectorhammett c44c33d
chore: add back release-please (firebase/php-jwt#640)
bshaffer 01f5577
chore(main): release 7.1.0 (firebase/php-jwt#641)
release-please[bot] a7df24d
chore: allow guzzlehttp/guzzle 8.0 (firebase/php-jwt#643)
scybulski 4e0167d
fix: limit the number of segments a JWT can be exploded into (firebas…
jeroen1602 e1adc3b
chore(main): release 7.1.1
release-please[bot] ed07db1
Merge pull request firebase/php-jwt#645 from googleapis/release-pleas…
Hectorhammett 5e266f8
chore: prepare the JWT library for migration to the monorepo
Hectorhammett 5348bad
chore: prepare for the JWT library migration
Hectorhammett cd17f15
merge 'php-jwt' into Jwt/
Hectorhammett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| * text=auto | ||
|
|
||
| /.gitattributes export-ignore | ||
| /.gitignore export-ignore | ||
| /.github export-ignore | ||
| /.php-cs-fixer.dist.php export-ignore | ||
| /phpstan.neon.dist export-ignore | ||
| /phpunit.xml.dist export-ignore | ||
| /tests export-ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| **PLEASE READ THIS ENTIRE MESSAGE** | ||
|
|
||
| Hello, and thank you for your contribution! Please note that this repository is | ||
| a read-only split of `googleapis/google-cloud-php`. As such, we are | ||
| unable to accept pull requests to this repository. | ||
|
|
||
| We welcome your pull request and would be happy to consider it for inclusion in | ||
| our library if you follow these steps: | ||
|
|
||
| * Clone the parent client library repository: | ||
|
|
||
| ```sh | ||
| $ git clone git@github.com:googleapis/google-cloud-php.git | ||
| ``` | ||
|
|
||
| * Move your changes into the correct location in that library. Library code | ||
| belongs in `Grafeas/src`, and tests in `Grafeas/tests`. | ||
|
|
||
| * Push the changes in a new branch to a fork, and open a new pull request | ||
| [here](https://github.com/googleapis/google-cloud-php). | ||
|
|
||
| Thanks again, and we look forward to seeing your proposed change! | ||
|
|
||
| The Google Cloud PHP team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| vendor | ||
| phpunit.phar | ||
| phpunit.phar.asc | ||
| composer.phar | ||
| composer.lock | ||
| .phpunit.result.cache | ||
| .php-cs-fixer.cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| return (new PhpCsFixer\Config()) | ||
| ->setRules([ | ||
| '@PSR2' => true, | ||
| 'concat_space' => ['spacing' => 'one'], | ||
| 'no_unused_imports' => true, | ||
| 'ordered_imports' => true, | ||
| 'new_with_braces' => true, | ||
| 'method_argument_space' => false, | ||
| 'whitespace_after_comma_in_array' => true, | ||
| 'return_type_declaration' => [ | ||
| 'space_before' => 'none' | ||
| ], | ||
| 'single_quote' => true, | ||
| 'native_function_invocation' => [ | ||
| 'strict' => false | ||
| ], | ||
| 'nullable_type_declaration' => [ | ||
| 'syntax' => 'question_mark', | ||
| ], | ||
| 'nullable_type_declaration_for_default_null_value' => true, | ||
| ]) | ||
| ->setFinder( | ||
| PhpCsFixer\Finder::create() | ||
| ->in(__DIR__) | ||
| ) | ||
| ; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.