Skip to content

chore: update .nycrc, Contributing.md, and .gitignore across packages - #9378

Draft
bshaffer wants to merge 1 commit into
mainfrom
revert-9354-revert-9144-pnpm-config-updates
Draft

bshaffer wants to merge 1 commit into
mainfrom
revert-9354-revert-9144-pnpm-config-updates

Conversation

@bshaffer

Copy link
Copy Markdown
Contributor

Reverts #9354

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes configuration files across multiple Google Cloud client packages by removing package-lock.json from .gitignore, removing redundant pnpm overrides from package.json, and updating .nycrc files to use a multi-line format that only includes the lcov reporter. The reviewer noted that packages/google-cloud-agentidentity/.nycrc was inconsistently formatted on a single line compared to the other updated .nycrc files and suggested formatting it consistently.

{
"report-dir": "./.coverage",
"reporter": ["text", "lcov"],
"reporter": ["lcov"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file uses a single-line format for the reporter array, whereas all other .nycrc files in this pull request use a multi-line format. Please format this consistently with the other packages to maintain uniform configuration style across the monorepo.

  "reporter": [
    "lcov"
  ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant