chore: revert update .nycrc, Contributing.md, and .gitignore across packages - #9354
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the workspace from pnpm to npm, updating installation and testing instructions in CONTRIBUTING.md files, adding package-lock.json to .gitignore files, and updating .nycrc configurations to include the 'text' reporter. Feedback on the changes highlights an asynchronous fs.unlink call in a synchronous afterEach hook in log-sync.ts that could lead to test flakiness, as well as a duplicate package-lock.json entry in the .gitignore file for gcp-metadata.
bshaffer
force-pushed
the
revert-9144-pnpm-config-updates
branch
from
September 16, 2026 16:10
8c91f35 to
fb90b48
Compare
quirogas
marked this pull request as ready for review
September 16, 2026 16:59
quirogas
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially revert #9144 by reverting all changes to the packages file. This changes will have to be propagated through the generator by releasing a new version of the generator, updating librarian.yaml, and re-generating all packages.