Skip to content

chore: update librarian version to v0.44.0 - #9340

Merged
zhumin8 merged 3 commits into
googleapis:mainfrom
zhumin8:chore-librarian-upgrade-2026-09-15
Sep 16, 2026
Merged

zhumin8 merged 3 commits into
googleapis:mainfrom
zhumin8:chore-librarian-upgrade-2026-09-15

Conversation

@zhumin8

@zhumin8 zhumin8 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Update librarian version to v0.44.0.

Debug Info

System Details

  • Node.js version: v22.23.2
  • npm version: 10.9.8
  • OS: Linux 6.18.14-1rodete4-amd64 x86_64
  • Librarian version: v0.44.0

Commands Executed

  • go run github.com/googleapis/librarian/cmd/librarian@latest update version
  • go run github.com/googleapis/librarian/cmd/librarian@v0.44.0 tidy
  • rm -rf "$HOME/.cache/librarian/bin/nodejs_tools"
  • go run github.com/googleapis/librarian/cmd/librarian@v0.44.0 install
  • go run github.com/googleapis/librarian/cmd/librarian@v0.44.0 generate --all
  • git add .
  • git commit -m "chore: update librarian version to v0.44.0"

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration version in librarian.yaml to v0.44.0 and replaces the usage of PoliciesClient with AccessPoliciesClient, PolicyBindingsClient, and PrincipalAccessBoundaryPoliciesClient in the system test sample fixtures for both JavaScript and TypeScript. No review comments were provided, so there is no feedback to address.

@zhumin8

zhumin8 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

This change does not look right.

@zhumin8

zhumin8 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Reverted the extra file changes. Turns out it was wrong introduced because gapic-node-processing setOnlyDefaultSystemTests incorrectly matches substring on absolute path. Filed separate issue for it.
By coincidence, this change used a random path containing "v2": "/tmp/upgrade-nodejs-v2Mp8W"

@zhumin8
zhumin8 marked this pull request as ready for review September 15, 2026 19:25
@zhumin8
zhumin8 merged commit 178d54f into googleapis:main Sep 16, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants