chore(gax): resolves linter warnings in gax - #9281
shivanee-p wants to merge 29 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several files in the @google-cloud/gax package, primarily focusing on formatting imports, type definitions, and converting unit tests in apiCallable.ts from callback-based (done) patterns to modern async/await syntax with assert.rejects. Feedback is provided regarding a skipped test in the unit tests, suggesting that an accompanying comment or TODO referencing a tracking issue should be added to explain the reason for skipping.
| }); | ||
|
|
||
| it.skip('retries with exponential backoff', done => { | ||
| it.skip('retries with exponential backoff', async () => { |
There was a problem hiding this comment.
When skipping a test, please ensure there is an accompanying comment or TODO that references the correct tracking issue and accurately describes the failure reason.
References
- When skipping a test, ensure the accompanying comment or TODO references the correct tracking issue and accurately describes the failure reason.
…nt premature span endings
…remature span closure tests
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…rest' in createApiCall
e2b5e2e to
6b5bd97
Compare
7d14d55 to
087aea5
Compare
| */ | ||
|
|
||
| import type {Response as NodeFetchResponse} from 'node-fetch' with {'resolution-mode': 'import'}; | ||
| import type {Response as NodeFetchResponse} from 'node-fetch' with { |
There was a problem hiding this comment.
Nit: commit 087aea5 ran Prettier across gax and reformatted imports in legacy files (fallbackServiceStub.ts, pagedApiCaller.ts, test/unit/pagedIteration.ts), which pulled pre-existing promise/* violations into the HEAD^1...HEAD diff window checked by linter.mjs --strict. One option is reverting the formatting-only churn on those three legacy files and keeping the targeted apiCallable.ts fixes so we avoid rewriting promise chains in the pagination and fallback stubs.
caa5b0d to
d03116a
Compare
5d7f1e4 to
b3d229c
Compare
65f3d84 to
fe93681
Compare
2 participants
No description provided.