Skip to content

chore(firestore): silence conformance logs and fix system test concurrency #9060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 2 commits into from
Aug 3, 2026
+2 −4
Merged

chore(firestore): silence conformance logs and fix system test concurrency #9060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c7cb34
chore(firestore): silence conformance logs and fix system test concur…
bshaffer Aug 3, 2026
9baab58
revert changes to firestore system-test concurrency
bshaffer Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions handwritten/firestore/dev/conformance/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,6 @@ function getHandler(spec: ConformanceProto) {
}

function runTest(spec: ConformanceProto) {
console.log(`Running Spec:\n${JSON.stringify(spec, null, 2)}\n`);

const updateTest = (spec: ConformanceProto) => {
const overrides = {commit: commitHandler(spec)};
return createInstance(overrides).then(() => {
Expand Down
4 changes: 2 additions & 2 deletions handwritten/firestore/dev/system-test/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1946,8 +1946,8 @@ describe('runs query on a large collection', () => {
let randomCol: CollectionReference;

beforeEach(async () => {
firestore = new Firestore({});
randomCol = getTestRoot(firestore);
randomCol = getTestRoot();
firestore = randomCol.firestore;

const promises: Array<Promise<DocumentReference<DocumentData>>> = [];
for (let i = 0; i < 1000; i++) {
Expand Down
Loading