fix(bigtable): test resource leaks, timestamp clamping, and metrics exporter - #9059
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the client-side metrics exporter to handle cases where the start time is greater than or equal to the end time, and stubs the OpenTelemetry metric reader in tests to use a faster export interval. Additionally, in the system tests, the instance reaping age is increased to 2 hours, and instances are now tagged with a creation timestamp. However, the reviewer correctly points out that changing the reaping logic to ignore instances without a 'time_created' label could lead to resource leaks if other tests create instances without this label.
westarle
left a comment
There was a problem hiding this comment.
it's a bit hard to review (e.g. the change in exporter.ts without knowing what the failure mode was.
When OpenTelemetry records very fast operations (or during system tests), it can emit metric data points where |
Separated from #9058 to isolate Bigtable CI fixes: