Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes README.md from the global default keep list in librarian.yaml and explicitly adds it to the keep configuration of individual libraries. It also updates the release level of google-cloud-agentidentity to preview and marks google-cloud-compute as stable, updating its README with new documentation links and samples. However, google-cloud-compute is missing the keep: - README.md configuration in librarian.yaml, meaning these manual README updates will be overwritten during the next regeneration.
| This library is considered to be **stable**. The code surface will not change in backwards-incompatible ways | ||
| unless absolutely necessary (e.g. because of critical security issues) or with | ||
| an extensive deprecation period. Issues and requests against **stable** libraries | ||
| are addressed with the highest priority. |
There was a problem hiding this comment.
Since README.md was removed from the global default keep list in librarian.yaml, any library that does not explicitly list README.md under its keep configuration will have its README.md overwritten or deleted during the next regeneration.
google-cloud-compute is currently missing keep: - README.md in librarian.yaml. Please add it to the google-cloud-compute library configuration in librarian.yaml to prevent these manual updates from being lost.
References
- Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.
2 participants
IGNORE.
Changes from running librarian generate --all on changes suggested by #9035