chore: test sharding with one package

.github/workflows/conformance.yaml → .github/workflows/bigtable-conformance.yaml

@@ -25,7 +25,7 @@
   pull_request:
     paths:
     - 'handwritten/bigtable/**'
-name: conformance
+name: bigtable-conformance
 jobs:
   conformance:
     runs-on: ubuntu-latest
@@ -36,16 +36,16 @@
       matrix:
         node: [ 18, 20 ]
     steps:
     - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
       with:
         persist-credentials: false
     - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
       with:
         repository: googleapis/cloud-bigtable-clients-test
         ref: main
         path: handwritten/bigtable/cloud-bigtable-clients-test
         persist-credentials: false
     - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
       with:
         node-version: ${{ matrix.node }}
     - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5

.github/workflows/presubmit.yaml

@@ -5,15 +5,37 @@
   pull_request:
 name: presubmit
 jobs:
+  setup:
+    runs-on: ubuntu-latest
+    outputs:
+      shard-matrix: ${{ steps.set-matrix.outputs.shard_matrix }}
+      shard-total: ${{ steps.set-matrix.outputs.shard_total }}
+    steps:
+      - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
+        with:
+          fetch-depth: 2
+          persist-credentials: false
+      - name: Calculate Matrix
+        id: set-matrix
+        run: |
+          export DRY_RUN_SHARDS=true
+          export BUILD_TYPE=presubmit
+          export TEST_TYPE=units
+          export GIT_DIFF_ARG=HEAD^1
+          bash ci/run_conditional_tests.sh
   units:
+    needs: setup
+    name: units (Node ${{ matrix.node-version }}, Shard ${{ matrix.shard-index }})
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         node-version: [22, 24, 26]
+        shard-index: ${{ fromJSON(needs.setup.outputs.shard-matrix) }}
     steps:
       - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
         with:
-          fetch-depth: 300
+          fetch-depth: 2
           persist-credentials: false
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
@@ -28,13 +50,16 @@
         env:
           BUILD_TYPE: presubmit
           TEST_TYPE: units
+          SHARD_TOTAL: ${{ needs.setup.outputs.shard-total }}
+          SHARD_INDEX: ${{ matrix.shard-index }}
+          GIT_DIFF_ARG: HEAD^1
   lint:
     runs-on: ubuntu-latest
     continue-on-error: true
     steps:
       - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
         with:
-          fetch-depth: 300
+          fetch-depth: 2
           persist-credentials: false
       - name: Use Node.js 24
         uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
@@ -43,3 +68,37 @@
       - run: npm install
       - run: npm run lint
         name: Run monorepo linter
+
+  # Dummy jobs to satisfy branch protection requirements for each node version
+  units-status:
+    name: units (${{ matrix.node-version }})
+    needs: units
+    runs-on: ubuntu-latest
+    if: always()
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [22, 24, 26]
+    steps:
+      - name: Check shard status
+        uses: actions/github-script@v6
+        with:
+          script: |
+            const { data: { jobs } } = await github.rest.actions.listJobsForWorkflowRun({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              run_id: context.runId,
+            });
+            const nodeVersion = '${{ matrix.node-version }}';
+            const shardJobs = jobs.filter(j => j.name.includes(`units (Node ${nodeVersion},`));
+            if (shardJobs.length === 0) {
+              core.setFailed(`No shard jobs found for Node ${nodeVersion}`);
+              return;
+            }
+            const failed = shardJobs.filter(j => j.conclusion === 'failure' || j.conclusion === 'cancelled');
+            if (failed.length > 0) {
+              const failedLinks = failed.map(j => `- ${j.name}: ${j.html_url}`).join('\n');
+              core.setFailed(`${failed.length} shards failed for Node ${nodeVersion}:\n${failedLinks}`);
+            } else {
+              core.info(`All shards passed for Node ${nodeVersion}`);
+            }

.github/workflows/conformance-test.yaml → .github/workflows/storage-conformance.yaml

@@ -10,15 +10,15 @@
   pull_request:
     paths:
       - 'handwritten/storage/**'
-name: conformance
+name: storage-conformance
 jobs:
   conformance-test:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
         with:
           persist-credentials: false
       - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version: 14
       - run: node --version

.github/workflows/windows-presubmit.yaml

@@ -5,15 +5,37 @@
   pull_request:
 name: presubmit-windows
 jobs:
+  setup:
+    runs-on: ubuntu-latest
+    outputs:
+      shard-matrix: ${{ steps.set-matrix.outputs.shard_matrix }}
+      shard-total: ${{ steps.set-matrix.outputs.shard_total }}
+    steps:
+      - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
+        with:
+          fetch-depth: 2
+          persist-credentials: false
+      - name: Calculate Matrix
+        id: set-matrix
+        run: |
+          export DRY_RUN_SHARDS=true
+          export BUILD_TYPE=presubmit
+          export TEST_TYPE=units
+          export GIT_DIFF_ARG=HEAD^1
+          bash ci/run_conditional_tests.sh
   units:
+    needs: setup
+    name: units (Node ${{ matrix.node-version }}, Shard ${{ matrix.shard-index }})
     runs-on: windows-latest
     strategy:
+      fail-fast: false
       matrix:
         node-version: [22, 24, 26]
+        shard-index: ${{ fromJSON(needs.setup.outputs.shard-matrix) }}
     steps:
       - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
         with:
-          fetch-depth: 300
+          fetch-depth: 2
           persist-credentials: false
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
@@ -29,3 +51,40 @@
         env:
           BUILD_TYPE: presubmit
           TEST_TYPE: units
+          SHARD_TOTAL: ${{ needs.setup.outputs.shard-total }}
+          SHARD_INDEX: ${{ matrix.shard-index }}
+          GIT_DIFF_ARG: HEAD^1
+
+  # Dummy jobs to satisfy branch protection requirements for each node version
+  units-status:
+    name: units (${{ matrix.node-version }})
+    needs: units
+    runs-on: ubuntu-latest
+    if: always()
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [22, 24, 26]
+    steps:
+      - name: Check shard status
+        uses: actions/github-script@v6
+        with:
+          script: |
+            const { data: { jobs } } = await github.rest.actions.listJobsForWorkflowRun({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              run_id: context.runId,
+            });
+            const nodeVersion = '${{ matrix.node-version }}';
+            const shardJobs = jobs.filter(j => j.name.includes(`units (Node ${nodeVersion},`));
+            if (shardJobs.length === 0) {
+              core.setFailed(`No shard jobs found for Node ${nodeVersion}`);
+              return;
+            }
+            const failed = shardJobs.filter(j => j.conclusion === 'failure' || j.conclusion === 'cancelled');
+            if (failed.length > 0) {
+              const failedLinks = failed.map(j => `- ${j.name}: ${j.html_url}`).join('\n');
+              core.setFailed(`${failed.length} shards failed for Node ${nodeVersion}:\n${failedLinks}`);
+            } else {
+              core.info(`All shards passed for Node ${nodeVersion}`);
+            }

ci/run_conditional_tests.sh

@@ -31,25 +31,27 @@ fi
 test_script="${PROJECT_ROOT}/ci/run_single_test.sh"
 
 
-if [ ${BUILD_TYPE} == "presubmit" ]; then
-    # For presubmit build, we want to know the difference from the
-    # common commit in origin/main.
-    GIT_DIFF_ARG="origin/main..."
-
-    # Then fetch enough history for finding the common commit.
-    git fetch origin main --deepen=300
-
-elif [ ${BUILD_TYPE} == "continuous" ]; then
-    # For continuous build, we want to know the difference in the last
-    # commit. This assumes we use squash commit when merging PRs.
-    GIT_DIFF_ARG="HEAD~.."
-
-    # Then fetch one last commit for getting the diff.
-    git fetch origin main --deepen=1
-
-else
-    # Run everything.
-    GIT_DIFF_ARG=""
+if [ -z "${GIT_DIFF_ARG}" ]; then
+    if [ ${BUILD_TYPE} == "presubmit" ]; then
+        # For presubmit build, we want to know the difference from the
+        # common commit in origin/main.
+        GIT_DIFF_ARG="origin/main..."
+
+        # Then fetch enough history for finding the common commit.
+        git fetch origin main --deepen=300
+
+    elif [ ${BUILD_TYPE} == "continuous" ]; then
+        # For continuous build, we want to know the difference in the last
+        # commit. This assumes we use squash commit when merging PRs.
+        GIT_DIFF_ARG="HEAD~.."
+
+        # Then fetch one last commit for getting the diff.
+        git fetch origin main --deepen=1
+
+    else
+        # Run everything.
+        GIT_DIFF_ARG=""
+    fi
 fi
 
 # Then detect changes in the test scripts.
@@ -62,10 +64,10 @@ if [[ "${changed}" -eq 0 ]]; then
     echo "no change detected in ci"
 else
     echo "skipping trigger of tests for now: tracking in #7540"
-    # echo "change detected in ci, we should test everything"
-    # echo "result of git diff ${GIT_DIFF_ARG} ci:"
-    # git diff ${GIT_DIFF_ARG} ci
-    # GIT_DIFF_ARG=""
+    #echo "change detected in ci, we should test everything"
+    #echo "result of git diff ${GIT_DIFF_ARG} ci:"
+    #git diff ${GIT_DIFF_ARG} ci
+    #GIT_DIFF_ARG=""
 fi
 
 # Now we have a fixed list, but we can change it to autodetect if
@@ -82,18 +84,21 @@ subdirs=(
 )
 
 RETVAL=0
-# These following APIs need an explicit credential file to run properly (or oAuth2, which we don't support in this repo). 
+# These following APIs need an explicit credential file to run properly (or oAuth2, which we don't support in this repo).
 # When we hit these packages, we will run the "samples with credentials" trigger, which contains the credentials as an env variable
 
 tests_with_credentials="core/packages/google-auth-library-nodejs/ packages/google-analytics-admin/ packages/google-area120-tables/ packages/google-analytics-data/ packages/google-iam-credentials/ packages/google-apps-meet/ packages/google-chat/ packages/google-streetview-publish/ packages/google-cloud-developerconnect/"
 
 # Some packages are only used by our bots and automation. These packages do not need to run on Windows and
 # often employ platform specific code like file system interaction. Some packages may also fail
 # on Windows due to incompatible npm scripts.
-# 
+#
 # Until these packages can be updated to be OS agnostic, we will skip them on Windows.
 windows_exempt_tests="core/ core/packages/ core/dev-packages/ .github/scripts/fixtures/ .github/scripts/tests/ core/packages/gapic-node-processing/ core/packages/typeless-sample-bot/ handwritten/cloud-profiler/"
 
+# Gather all test directories into an array
+test_dirs=()
+
 for subdir in ${subdirs[@]}; do
     for d in `ls -d ${subdir}/*/`; do
         if [ -s "ignore.json" ] && jq -e ".ignored[] | select(. == \"$d\")" ignore.json > /dev/null 2>&1; then
@@ -116,7 +121,7 @@ for subdir in ${subdirs[@]}; do
         # System tests for packages are broken and blocking PRs.
         # See https://github.com/googleapis/google-cloud-node/issues/7976.
         #
-        # Per https://github.com/googleapis/google-cloud-node/issues/7921, 
+        # Per https://github.com/googleapis/google-cloud-node/issues/7921,
         # we are likely to permanently remove these tests in the near future.
         if [[ "${subdir}" == "packages" && "${TEST_TYPE}" == "system" ]]; then
             echo "Skipping ${TEST_TYPE} test for packages: ${d}"
@@ -126,7 +131,7 @@ for subdir in ${subdirs[@]}; do
         # Sample tests for packages are broken/flaky and blocking PRs.
         # See https://github.com/googleapis/google-cloud-node/issues/7976#issuecomment-4210458096.
         #
-        # Per https://github.com/googleapis/google-cloud-node/issues/7921, 
+        # Per https://github.com/googleapis/google-cloud-node/issues/7921,
         # we are likely to permanently remove these tests in the near future.
         if [[ "${subdir}" == "packages" && "${TEST_TYPE}" == "samples" ]]; then
             echo "Skipping ${TEST_TYPE} test for packages: ${d}"
@@ -204,21 +209,44 @@ for subdir in ${subdirs[@]}; do
             fi
         fi
         if [ "${should_test}" = true ]; then
-            echo "running test in ${d}"
-            pushd ${d}
-            # Temporarily allow failure.
-            set +e
-            ${test_script}
-            ret=$?
-            set -e
-            if [ ${ret} -ne 0 ]; then
-                RETVAL=${ret}
-                # Since there are so many APIs, we should exit early if there's an error
-                exit ${RETVAL}
-            fi
-            popd
+            test_dirs+=("${d}")
         fi
     done
 done
+# If DRY_RUN_SHARDS is set, output dynamic matrix values to GitHub Actions and exit
+if [[ "${DRY_RUN_SHARDS}" == "true" ]]; then
+    count=${#test_dirs[@]}
+    if [[ $count -gt 15 ]]; then
+        echo "shard_matrix=[0, 1, 2, 3, 4]" >> $GITHUB_OUTPUT
+        echo "shard_total=5" >> $GITHUB_OUTPUT
+    else
+        echo "shard_matrix=[0]" >> $GITHUB_OUTPUT
+        echo "shard_total=1" >> $GITHUB_OUTPUT
+    fi
+    exit 0
+fi
+
+# If SHARD_TOTAL and SHARD_INDEX are provided, we will only run a subset of the tests.
+for i in "${!test_dirs[@]}"; do
+    d="${test_dirs[$i]}"
+
+    if [[ -n "${SHARD_TOTAL}" && -n "${SHARD_INDEX}" ]]; then
+        if (( i % SHARD_TOTAL != SHARD_INDEX )); then
+            continue
+        fi
+    fi
+
+    echo "running test in ${d}"
+    pushd ${d} >/dev/null
+    # Temporarily allow failure.
+    set +e
+    ${test_script}
+    ret=$?
+    set -e
+    if [ ${ret} -ne 0 ]; then
+        exit ${ret}
+    fi
+    popd >/dev/null
+done
 
-exit ${RETVAL}
+exit 0

ci/run_single_test.sh

@@ -37,6 +37,8 @@ if [ ${BUILD_TYPE} != "presubmit" ]; then
     export MOCHA_REPORTER_OUTPUT=${PROJECT}_sponge_log.xml
     export MOCHA_REPORTER_SUITENAME=${PROJECT}
     export MOCHA_REPORTER=xunit
+else
+    export MOCHA_REPORTER=dot
 fi
 
 # Install dependencies
@@ -47,8 +49,8 @@ if command -v cygpath >/dev/null 2>&1; then
     PNPMFILE_PATH=$(cygpath -m "${PNPMFILE_PATH}")
 fi
 
-echo "pnpm install --ignore-scripts --engine-strict --prod --pnpmfile \"${PNPMFILE_PATH}\"; pnpm install --pnpmfile \"${PNPMFILE_PATH}\""
-pnpm install --ignore-scripts --engine-strict --prod --pnpmfile "${PNPMFILE_PATH}"; pnpm install --pnpmfile "${PNPMFILE_PATH}"
+echo "pnpm install --reporter=silent --engine-strict --pnpmfile \"${PNPMFILE_PATH}\""
+pnpm install --reporter=silent --engine-strict --pnpmfile "${PNPMFILE_PATH}"
 
 
 retval=0

core/dev-packages/pack-n-play/test/fixtures/esm-package/test/test.js

@@ -16,7 +16,8 @@ import {packNTest} from 'pack-n-play';
 import * as assert from 'assert';
 import {describe, it} from 'mocha';
 
-describe('ESM package', () => {
+describe('ESM package', function () {
+  this.timeout(120000);
   it('should support esm property', () =>
     packNTest({
       sample: {

core/dev-packages/pack-n-play/test/fixtures/leaky/test/test.ts

@@ -16,7 +16,8 @@ import {packNTest} from 'pack-n-play';
 import * as assert from 'assert';
 import {describe, it} from 'mocha';
 
-describe('leaky tests', () => {
+describe('leaky tests', function () {
+  this.timeout(120000);
   it('should fail packing n testing', async () => {
     await assert.rejects(
       packNTest({