feat!: upgrade minimum Node.js version to 22 - #9026
Draft
danieljbruce wants to merge 19 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the google-gax dependency to ^6.0.0 and the Node.js engine requirement to >=22 across multiple packages and baselines. Additionally, it introduces new baseline configuration files for ESLint and Mocha. I have no feedback to provide.
This reverts commit 3654ef3.
This reverts commit cffbb32.
This reverts commit c60918a.
…into node-22-bump-generator-version # Conflicts: # .github/workflows/continuous.yaml # .github/workflows/presubmit.yaml # .github/workflows/windows-presubmit.yaml
…into node-22-bump-generator-version # Conflicts: # .github/workflows/continuous.yaml # .github/workflows/presubmit.yaml # .github/workflows/windows-presubmit.yaml
…oogleapis/google-cloud-node into node-22-bump-generator-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade all generated packages to Node 22 along with their dependencies.
For all
package.jsonfiles insidepackages/**folder we set "node": ">=22" forengines. We also make sure that for all of thesepackage.jsonfiles the dependencies that match the core libraries are all on the latest version so that all core library dependencies correspond to node v22.Note that a branch update is likely required to get the zizmor checks to pass.
Impact
Encourages customers to adopt new Node version which avoids issues due to lack of Node 18 support.