fix: handle bytes in map and repeated fields in toProto3JSON#8351
fix: handle bytes in map and repeated fields in toProto3JSON#8351mjameswh wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds support for bytes fields within maps and repeated fields in the proto3-json-serializer-nodejs package. It updates the proto definitions, test fixtures, and the serialization logic in toproto3json.ts by moving the byte conversion logic into convertSingleValue. New unit tests for map and repeated byte fields are also included. I have no feedback to provide.
|
For info, I believe our company has already signed the CLA; I'm working internally on getting added to the authorized list of emails. |
Summary
toProto3JSONfailed to base64-encodebytesvalues inside map and repeated fieldsBuffer/Uint8Arrayhandling intoconvertSingleValueso it applies everywhere, not just top-level fieldsFixes #7704