Repository navigation
chore(kokoro): fix maven shared install locking issue on osx - #14895
sakthivelmanii wants to merge 4 commits into
Conversation
Adds GCS Central mirror settings to Maven execution and configures aether timeout to fail fast on stalled network connections in order to release NamedLocks.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request configures Maven retry and timeout options (-Daether.connector.http.retryHandler.count and -Daether.connector.requestTimeout) across several build and test steps in .kokoro/build.sh and .kokoro/common.sh. The feedback highlights multiple instances where these new options were accidentally duplicated within the same command blocks, as well as an indentation inconsistency in .kokoro/common.sh that should be corrected.
There was a problem hiding this comment.
Code Review
This pull request configures additional Maven properties ("-Daether.connector.http.retryHandler.count" and "-Daether.connector.requestTimeout") across several build and test commands in ".kokoro/build.sh" and ".kokoro/common.sh". However, the changes introduce redundant duplicate lines of these properties and some inconsistent indentation. The review comments correctly identify these issues and provide suggestions to clean up the formatting and remove the duplicate entries.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request configures the Aether connector retry count and request timeout properties across several Maven invocations in the Kokoro build and common scripts to improve build reliability. The feedback suggests formatting a long Maven command in .kokoro/common.sh by splitting the options across multiple lines to improve readability and maintain consistency.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request configures Maven HTTP retry counts and request timeouts in the Kokoro build and common scripts. However, in .kokoro/common.sh, empty lines were introduced within multi-line command continuations, which will break the Bash execution and cause "command not found" errors. These empty lines should be removed, and the indentation should be corrected to match the surrounding lines.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds Aether HTTP retry and request timeout configurations to the Maven commands in .kokoro/build.sh and .kokoro/common.sh. The feedback highlights several indentation inconsistencies in the newly added lines and provides suggestions to align them with the surrounding code.
Problem
Solution