[sakthivelmanii]

Problem

• The test ReadWriteTransactionWithInlineBeginTest#closeBeforeTransactionIdReturnedDoesNotRaceWithCancelledConsumer synchronizes on mockSpanner.waitForRequestsToContain(ExecuteSqlRequest.class), but the server sees this inside request.start(...) before setCall() and ResumableStreamIterator.setStream() complete, causing a race where resultSet.close() cancels nothing and the consumer thread deadlocks awaiting its own cancellation latch (TimeoutException).

Solution

• Synchronize directly on the prefetch request() call via streamRegisteredLatch.countDown(), which only executes after setStream() returns, guaranteeing that resultSet.close() cancels the registered stream from the closing thread.
• Record the consumer thread in consumerThread and only await consumerFinishedNextLatch inside cancel() when invoked from an external thread, preventing self-deadlock if cancel() is ever called on the consumer thread itself.

[sakthivelmanii]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates a test in ReadWriteTransactionWithInlineBeginTest.java to use a CountDownLatch (streamRegisteredLatch) to synchronize and wait for the stream to be registered before closing the result set, replacing a wait for mock Spanner requests. However, calling streamRegisteredLatch.await(...) throws a checked InterruptedException which is unhandled in the current lambda context, causing a compilation error. It is recommended to wrap this call in a try-catch block and restore the thread's interrupted status.

[gemini-code-assist]

Code Review

This pull request updates a test in ReadWriteTransactionWithInlineBeginTest.java to use a CountDownLatch (streamRegisteredLatch) to synchronize the stream registration before closing the result set, replacing a time-based wait for requests. However, calling streamRegisteredLatch.await throws a checked InterruptedException which is not handled inside the lambda expression, leading to a compilation error. It is recommended to wrap this call in a try-catch block, restore the interrupted status, and throw a RuntimeException to ensure the test compiles and fails correctly if interrupted.

[sakthivelmanii]

/gemini review

[gemini-code-assist]

Code Review

This pull request improves synchronization in the ReadWriteTransactionWithInlineBeginTest class by introducing a streamRegisteredLatch and tracking the consumerThread to prevent race conditions and self-deadlocks during stream cancellation. The reviewer recommends improving the handling of InterruptedException within the cancel method by throwing a RuntimeException instead of swallowing it, which ensures that the test fails immediately and clearly upon interruption.