Repository navigation
fix(bigtable): reject empty split points in RowSetUtil and clarify QueryPaginator Javadoc - #14811
Merged
Merged
Conversation
…eryPaginator Javadoc
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces input validation to RowSetUtil by ensuring that erase and eraseLargeRow reject empty keys with an IllegalArgumentException, supported by new unit tests. Additionally, it updates the Javadoc in Query.java to fix a code example and clarify the usage of the advance method. There are no review comments, and we have no feedback to provide.
mutianf
approved these changes
Oct 28, 2026
igorbernstein2
enabled auto-merge (squash)
October 28, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify
Query.QueryPaginator#advanceJavadoc and example usage, and reject empty keys inRowSetUtil#eraseandRowSetUtil#eraseLargeRow.