[nidhiii-27]

Summary

Implements the gcp.storage.client.request.body.size metric for WriteObject operations across HTTP and gRPC transports.

Changes

• StorageMetricsContext:
  • Adds setRequestBytes(long) and addRequestBytes(long) for tracking request payload size.
  • Records gcp.storage.client.request.body.size in recordOperation() when operationName is "WriteObject" and requestBytes > 0, filtering out attempt-only and HTTP-only attributes via buildBodySizeAttributes(...).
• BaseStorageWriteChannel:
  • Accumulates written bytes on metricsContext via addRequestBytes(write) during write(ByteBuffer) and records once on close().
• StorageImpl & GrpcStorageImpl:
  • Instruments create(BlobInfo, ...) overloads (byte[], InputStream), createFrom(BlobInfo, Path, ...), createFrom(BlobInfo, InputStream, ...), and internalCreateFrom(Path, BlobInfo, Opts<ObjectTargetOpt>) to record request payload size on WriteObject metrics contexts.
  • Separates the 3-argument StorageInternal.internalDirectUpload(BlobInfo, Opts<ObjectTargetOpt>, ByteBuffer) hook (used by ParallelCompositeUploadWritableByteChannel part uploads) from the private 4-argument helper so PCU part uploads do not double-count WriteObject operations or request body bytes.
• StorageMetricsContextTest:
  • Adds unit tests verifying gcp.storage.client.request.body.size recording, attribute filtering (BODY_SIZE_EXCLUDED_KEYS), 0-byte and non-WriteObject suppression, BaseStorageWriteChannel write accumulation, StorageImpl and GrpcStorageImpl write entrypoints, and PCU internalDirectUpload suppression.

[gemini-code-assist]

Code Review

This pull request introduces request body size tracking for 'WriteObject' operations in Google Cloud Storage by capturing and recording request bytes in the StorageMetricsContext. However, a critical compilation error was identified in GrpcStorageImpl.java where Files.size(path) is called outside of a try-catch block, throwing an unhandled checked IOException. Moving this call inside the try block will resolve the compilation issue and ensure proper exception handling.

[gemini-code-assist]

Code Review

This pull request implements tracking and recording of request body sizes for 'WriteObject' operations across various storage implementation classes, including BaseStorageWriteChannel, GrpcStorageImpl, and StorageImpl, using StorageMetricsContext. It also adds unit tests to verify this behavior. A review comment suggests moving the Files.size(path) call inside the try block in GrpcStorageImpl.java to ensure that any potential IOException is properly caught and handled by the existing error-handling logic.