Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several Maven project dependencies and parent POM versions from SNAPSHOTs to stable releases, specifically setting the google-cloud-bigquery-jdbc version to 1.4.1. A review comment correctly points out that in versions.txt, the development version for google-cloud-bigquery-jdbc was incorrectly set to 1.4.1 instead of a SNAPSHOT version, violating the required format.
| grpc-google-cloud-vectorsearch-v1:0.19.0:0.20.0-SNAPSHOT | ||
| google-cloud-bigquery:2.71.0:2.72.0-SNAPSHOT | ||
| google-cloud-bigquery-jdbc:1.4.0:1.5.0-SNAPSHOT | ||
| google-cloud-bigquery-jdbc:1.4.1:1.4.1 |
There was a problem hiding this comment.
In versions.txt, the format is <artifactId>:<released-version>:<development-version>. Setting both the released version and the development version to 1.4.1 (i.e., 1.4.1:1.4.1) is incorrect because the development version should be a SNAPSHOT version (e.g., 1.5.0-SNAPSHOT or 1.4.2-SNAPSHOT). Please update the development version accordingly.
google-cloud-bigquery-jdbc:1.4.1:1.5.0-SNAPSHOT
Bumps
java-bigquery-jdbcto version 1.4.1 and updates SNAPSHOT dependencies it references to their previously released versions:google-cloud-bigquery-jdbc: bumped to1.4.1google-cloud-jar-parent:1.92.0-SNAPSHOT->1.91.0google-cloud-bigquery:2.72.0-SNAPSHOT->2.71.0google-cloud-bigquerystorage:3.34.0-SNAPSHOT->3.33.0google-cloud-logging:3.39.0-SNAPSHOT->3.38.0proto-google-cloud-bigquerystorage-v1:3.34.0-SNAPSHOT->3.33.0google-cloud-trace:2.98.0-SNAPSHOT->2.97.0