test(bigquery-jdbc): isolate PCNT tests and add disable_tpc tag - #14388
Open
keshavdandeva wants to merge 3 commits into
Open
keshavdandeva wants to merge 3 commits into
keshavdandeva wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests by extracting PCNT-related tests from ITConnectionTest and ITDatabaseMetadataTest into a new dedicated test class, ITPcntTest, which is also added to the ITPresubmitTests suite. The review feedback highlights a critical compilation error in ITPcntTest due to the missing definition of DEFAULT_CATALOG, and suggests cleaning up the now-empty @afterall methods in both ITConnectionTest and ITDatabaseMetadataTest.
logachev
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/561965004
This PR decouples PCNT ITs from core connection and metadata test classes into a dedicated class tagged with
@Tag("disable_tpc").Changes
ITPcntTest: Created a dedicated integration test class containing the 5 PCNT tests (2 connection, 3 metadata) and tagged it with@Tag("disable_tpc")at class levelITConnectionTest&ITDatabaseMetadataTest: Removed PCNT table lifecycle (setUpPcntTable/cleanUpPcntTable) and PCNT test methods. Core tests now run independently in TPC.ITPresubmitTests: AddedITPcntTestto preserve full test coverage in standard GCP presubmit CI.