chore: update googleapis commitish to c5dcac8 - #13968
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new SearchMessages method to the Google Chat API, including the necessary protocol buffer definitions, client library updates, and documentation. I have identified an issue in the generated sample code where the ApiFuture return type was incorrectly specified, which would lead to compilation errors for users. The suggested fix has been provided in the review comments.
| * ApiFuture<SearchMessageResult> future = | ||
| * chatServiceClient.searchMessagesPagedCallable().futureCall(request); |
There was a problem hiding this comment.
The generic type for ApiFuture in this sample code is incorrect. The searchMessagesPagedCallable().futureCall() method returns an ApiFuture<SearchMessagesPagedResponse>, not ApiFuture<SearchMessageResult>. This will cause a compilation error for users who copy this example.
| * ApiFuture<SearchMessageResult> future = | |
| * chatServiceClient.searchMessagesPagedCallable().futureCall(request); | |
| * ApiFuture<SearchMessagesPagedResponse> future = | |
| * chatServiceClient.searchMessagesPagedCallable().futureCall(request); |
1 participant
Updated googleapis commitish in librarian.yaml to googleapis/googleapis@c5dcac8
💡 Note: If this PR is still open when the daily update workflow runs next, it will be closed and replaced with a new PR containing the latest updates.