fix(sql): ran mvn formatting commands on generated gRPC stub files - #13958
Draft
nnicolee wants to merge 1 commit into
Draft
fix(sql): ran mvn formatting commands on generated gRPC stub files#13958nnicolee wants to merge 1 commit into
nnicolee wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up the codebase by removing an extra blank line before the class-level Javadoc comments in several gRPC service files, including SqlAvailableDatabaseVersionsServiceGrpc, SqlEventsServiceGrpc, SqlFeatureEligibilityServiceGrpc, SqlIamPoliciesServiceGrpc, SqlInstanceNamesServiceGrpc, and SqlRegionsServiceGrpc. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Formats the 6 generated gRPC stub files in
java-sql/grpc-google-cloud-sql-v1.Root Cause
These files were generated by
protoc-gen-grpc-javaand checked in without running a post-generationmvn fmt:formatpass. As a result, PRs running full-repo lint checks were encounteringfmt:checkfailures.Changes
mvn fmt:format -pl java-sql/grpc-google-cloud-sql-v1.Verification
mvn fmt:check -pl java-sql/grpc-google-cloud-sql-v1:Processed 16 files (0 non-complying). BUILD SUCCESS