Skip to content

refactor(bigquery): resolve circular test dependency with bigquerystorage - #13949

Open
jinseopkim0 wants to merge 3 commits into
mainfrom
move-bqstorage-it
Open

refactor(bigquery): resolve circular test dependency with bigquerystorage#13949
jinseopkim0 wants to merge 3 commits into
mainfrom
move-bqstorage-it

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #12700.

Moves all integration tests depending on java-bigquery veneer client from java-bigquerystorage to java-bigquery to eliminate the circular test dependency between the two modules.

Kokoro Configuration Updates

  • Added INTEGRATION_TEST_ARGS (-Dit.test=!ITBigQueryWrite*RetryTest -Dsurefire.failIfNoSpecifiedTests=false -Dfailsafe.failIfNoSpecifiedTests=false) to bigquery-integration.cfg and bigquery-graalvm-native-presubmit.cfg.
  • Note on test exclusions: This preserves existing presubmit behavior by mirroring the exact INTEGRATION_TEST_ARGS exclusions previously configured in bigquerystorage-integration.cfg and bigquerystorage-graalvm-native-presubmit.cfg to skip heavy write retry integration tests during PR presubmits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the project by moving integration tests from java-bigquerystorage to java-bigquery, updating the respective pom.xml dependencies, and adjusting the Kokoro build script to trigger java-bigquery tests when java-bigquerystorage is modified. Feedback suggests replacing the Bash string-matching array membership check with a more robust loop to avoid anti-patterns, and warns against manually editing auto-generated pom.xml files to prevent changes from being overwritten.

Comment thread .kokoro/common.sh Outdated
Comment thread java-bigquery/google-cloud-bigquery/pom.xml
@jinseopkim0

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves several integration tests from java-bigquerystorage to java-bigquery, updating the respective Maven configurations and the Kokoro build script to handle dependencies and module detection. Feedback suggests simplifying the duplicate-checking logic in .kokoro/common.sh using bash regex patterns and adding the arrow-memory-netty test dependency to java-bigquery's POM to prevent initialization errors during Arrow-based test execution.

Comment thread java-bigquery/google-cloud-bigquery/pom.xml
Comment thread .kokoro/common.sh
@jinseopkim0
jinseopkim0 marked this pull request as ready for review July 29, 2026 20:56
@jinseopkim0
jinseopkim0 requested review from a team as code owners July 29, 2026 20:56
@jinseopkim0
jinseopkim0 requested a review from lqiu96 July 29, 2026 20:56
@jinseopkim0
jinseopkim0 force-pushed the move-bqstorage-it branch 2 times, most recently from 752c2f2 to 290cc57 Compare July 31, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java-bigquery] circular test dependency between bigquery and bigquerystorage

1 participant