refactor(bigquery): resolve circular test dependency with bigquerystorage - #13949
refactor(bigquery): resolve circular test dependency with bigquerystorage#13949jinseopkim0 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request restructures the project by moving integration tests from java-bigquerystorage to java-bigquery, updating the respective pom.xml dependencies, and adjusting the Kokoro build script to trigger java-bigquery tests when java-bigquerystorage is modified. Feedback suggests replacing the Bash string-matching array membership check with a more robust loop to avoid anti-patterns, and warns against manually editing auto-generated pom.xml files to prevent changes from being overwritten.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request moves several integration tests from java-bigquerystorage to java-bigquery, updating the respective Maven configurations and the Kokoro build script to handle dependencies and module detection. Feedback suggests simplifying the duplicate-checking logic in .kokoro/common.sh using bash regex patterns and adding the arrow-memory-netty test dependency to java-bigquery's POM to prevent initialization errors during Arrow-based test execution.
752c2f2 to
290cc57
Compare
290cc57 to
f78f628
Compare
Fixes #12700.
Moves all integration tests depending on
java-bigqueryveneer client fromjava-bigquerystoragetojava-bigqueryto eliminate the circular test dependency between the two modules.Kokoro Configuration Updates
INTEGRATION_TEST_ARGS(-Dit.test=!ITBigQueryWrite*RetryTest -Dsurefire.failIfNoSpecifiedTests=false -Dfailsafe.failIfNoSpecifiedTests=false) tobigquery-integration.cfgandbigquery-graalvm-native-presubmit.cfg.INTEGRATION_TEST_ARGSexclusions previously configured inbigquerystorage-integration.cfgandbigquerystorage-graalvm-native-presubmit.cfgto skip heavy write retry integration tests during PR presubmits.